[Bug build/31385] New: sort-makefile-lines.py doesn't check variable with _

["hjl.tools at gmail dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=31385

            Bug ID: 31385
           Summary: sort-makefile-lines.py doesn't check variable with _
           Product: glibc
           Version: 2.40
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

There are many Makefile variable names with _:

sysdeps/aarch64/Makefile:sysdep_headers += sys/ifunc.h
sysdeps/aarch64/Makefile:sysdep_routines += \
sysdeps/aarch64/Makefile:sysdep_malloc_debug_routines = __mtag_tag_zero_region
__mtag_tag_region
...

But sort-makefile-lines.py doesn't include _ in

    # Build a list of all start markers (tuple includes name).
    startmarks = []
    for i in range(len(lines)):
        # Look for things like "var = \", "var := \" or "var += \"
        # to start the sorted list.
        var = re.search(r'^([a-zA-Z0-9-]*) [\+:]?\= \\$', lines[i])

-- 
You are receiving this mail because:
You are on the CC list for the bug.