[Bug malloc/31553] New: elf/tst-decorate-maps fails on ppc64el

[Bug malloc/31553] New: elf/tst-decorate-maps fails on ppc64el

[simon.chopin at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31553

            Bug ID: 31553
           Summary: elf/tst-decorate-maps fails on ppc64el
           Product: glibc
           Version: 2.39
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: malloc
          Assignee: unassigned at sourceware dot org
          Reporter: simon.chopin at canonical dot com
  Target Milestone: ---

Using the Ubuntu kernels (e.g. 6.5.0-26-generic from Mantic, but also the ones
in the upcoming Noble), the glibc test suite fails on

FAIL: elf/tst-decorate-maps
original exit status 1
error: tst-decorate-maps.c:152: not true: r.n_loader_malloc_mmap >= 1
error: tst-decorate-maps.c:167: not true: r.n_loader_malloc_mmap >= 1
error: tst-decorate-maps.c:152: not true: r.n_loader_malloc_mmap >= 1
error: tst-decorate-maps.c:167: not true: r.n_loader_malloc_mmap >= 1
error: 4 test failures

Tested on upstream master branch (as of dc1a77269c "htl: Implement some support
for TLS_DTV_AT_TP"), release/2.39/master, as well as the Ubuntu package.

I couldn't see anything particularly relevant in the system logs.

(assigning to malloc component since this seems to be primarily about
allocations)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/31553] elf/tst-decorate-maps fails on ppc64el

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31553

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
Does the kernel use 64k pages?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/31553] elf/tst-decorate-maps fails on ppc64el

[simon.chopin at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31553

--- Comment #2 from Simon Chopin <simon.chopin at canonical dot com> ---
(In reply to Andreas Schwab from comment #1)
> Does the kernel use 64k pages?

$ getconf PAGESIZE
65536

I guess it does.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/31553] elf/tst-decorate-maps fails on ppc64el

[simon.chopin at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31553

Simon Chopin <simon.chopin at canonical dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

--- Comment #3 from Simon Chopin <simon.chopin at canonical dot com> ---
Thanks Andreas for pointing me to the page size.

There's an assumption made in the test that the early allocation code will need
to grow beyond the initial data page, as those extra pages would be the ones
marked "[anon: glibc: loader malloc]". However, if the page size is large
enough, I guess that assumption isn't valid anymore.

I'll write a patch skipping this particular assertion if the page size is 64k
or above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/31553] elf/tst-decorate-maps fails on ppc64el

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31553

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #4 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to Simon Chopin from comment #3)
> Thanks Andreas for pointing me to the page size.
> 
> There's an assumption made in the test that the early allocation code will
> need to grow beyond the initial data page, as those extra pages would be the
> ones marked "[anon: glibc: loader malloc]". However, if the page size is
> large enough, I guess that assumption isn't valid anymore.
> 
> I'll write a patch skipping this particular assertion if the page size is
> 64k or above.

I could reproduce it on a ppc64le VM, and it seems to what you described: the
__minimal_malloc never issues the mmap because the initial data segment can
supply the loader memory requirement.  I think without a way to trigger the
load mmap allocation, it would be better to just remove the 'loader malloc'
check (it might be that we will need to adjust for possible different page
sizes).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug malloc/31553] elf/tst-decorate-maps fails on ppc64el

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31553

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Target Milestone|---                         |2.40
         Resolution|---                         |FIXED

--- Comment #5 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
Fixed on 2.40.

-- 
You are receiving this mail because:
You are on the CC list for the bug.