public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Avoid compat symbols for totalorder in powerpc64le IEEE long double
@ 2019-12-23 20:55 Gabriel F.T.Gomes
0 siblings, 0 replies; only message in thread
From: Gabriel F.T.Gomes @ 2019-12-23 20:55 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f8cd1020817fd6b69446b4308b496de999934ef8
commit f8cd1020817fd6b69446b4308b496de999934ef8
Author: Gabriel F. T. Gomes <gabrielftg@linux.ibm.com>
Date: Mon Sep 9 12:59:46 2019 -0500
Avoid compat symbols for totalorder in powerpc64le IEEE long double
On powerpc64le, the libm_alias_float128_other_r_ldbl macro is
used to create an alias between totalorderf128 and __totalorderlieee128,
as well as between the totalordermagf128 and __totalordermaglieee128.
However, the totalorder* and totalordermag* functions changed their
parameter type since commit ID 42760d764649 and got compat symbols for
their old versions. With this change, the aforementioned macro would
create two conflicting aliases for __totalorderlieee128 and
__totalordermaglieee128.
This patch avoids the creation of the alias between the IEEE long double
symbols (__totalorderl*ieee128) and the compat symbols, because the IEEE
long double functions have never been exported thus don't need such
compat symbol.
Tested for powerpc64le.
Reviewed-by: Joseph Myers <joseph@codesourcery.com>
Diff:
---
sysdeps/ieee754/ldbl-128/s_totalorderl.c | 9 +++++++++
sysdeps/ieee754/ldbl-128/s_totalordermagl.c | 9 +++++++++
2 files changed, 18 insertions(+)
diff --git a/sysdeps/ieee754/ldbl-128/s_totalorderl.c b/sysdeps/ieee754/ldbl-128/s_totalorderl.c
index 098bd2b..f9db06c 100644
--- a/sysdeps/ieee754/ldbl-128/s_totalorderl.c
+++ b/sysdeps/ieee754/ldbl-128/s_totalorderl.c
@@ -74,6 +74,15 @@ __totalorder_compatl (_Float128 x, _Float128 y)
{
return __totalorderl (&x, &y);
}
+/* On platforms that reuse the _Float128 implementation for IEEE long
+ double (powerpc64le), the libm_alias_float128_other_r_ldbl macro
+ (which is called by the libm_alias_ldouble macro) is used to create
+ aliases between *f128 (_Float128 API) and __*ieee128 functions.
+ However, this compat version of totalorderl is older than the
+ availability of __ieee*128 symbols, thus, the compat alias is not
+ required, nor desired. */
+#undef libm_alias_float128_other_r_ldbl
+#define libm_alias_float128_other_r_ldbl(from, to, r)
#undef do_symbol
#define do_symbol(orig_name, name, aliasname) \
strong_alias (orig_name, name) \
diff --git a/sysdeps/ieee754/ldbl-128/s_totalordermagl.c b/sysdeps/ieee754/ldbl-128/s_totalordermagl.c
index b31788c..45b17ed 100644
--- a/sysdeps/ieee754/ldbl-128/s_totalordermagl.c
+++ b/sysdeps/ieee754/ldbl-128/s_totalordermagl.c
@@ -68,6 +68,15 @@ __totalordermag_compatl (_Float128 x, _Float128 y)
{
return __totalordermagl (&x, &y);
}
+/* On platforms that reuse the _Float128 implementation for IEEE long
+ double (powerpc64le), the libm_alias_float128_other_r_ldbl macro
+ (which is called by the libm_alias_ldouble macro) is used to create
+ aliases between *f128 (_Float128 API) and __*ieee128 functions.
+ However, this compat version of totalordermagl is older than the
+ availability of __ieee*128 symbols, thus, the compat alias is not
+ required, nor desired. */
+#undef libm_alias_float128_other_r_ldbl
+#define libm_alias_float128_other_r_ldbl(from, to, r)
#undef do_symbol
#define do_symbol(orig_name, name, aliasname) \
strong_alias (orig_name, name) \
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-23 20:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-23 20:55 [glibc] Avoid compat symbols for totalorder in powerpc64le IEEE long double Gabriel F.T.Gomes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).