public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Linux: Use faccessat2 to implement faccessat (bug 18683)
@ 2020-08-07 20:07 Florian Weimer
0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2020-08-07 20:07 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3d3ab573a5f3071992cbc4f57d50d1d29d55bde2
commit 3d3ab573a5f3071992cbc4f57d50d1d29d55bde2
Author: Florian Weimer <fweimer@redhat.com>
Date: Fri Aug 7 22:06:59 2020 +0200
Linux: Use faccessat2 to implement faccessat (bug 18683)
This provides correct AT_EACCESS handling and also takes
Linux security modules into account.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diff:
---
sysdeps/unix/sysv/linux/faccessat.c | 14 +++++++++++---
sysdeps/unix/sysv/linux/kernel-features.h | 8 ++++++++
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/sysdeps/unix/sysv/linux/faccessat.c b/sysdeps/unix/sysv/linux/faccessat.c
index e4f18ab2db..56cb6dcc8b 100644
--- a/sysdeps/unix/sysv/linux/faccessat.c
+++ b/sysdeps/unix/sysv/linux/faccessat.c
@@ -30,6 +30,13 @@
int
faccessat (int fd, const char *file, int mode, int flag)
{
+ int ret = INLINE_SYSCALL_CALL (faccessat2, fd, file, mode, flag);
+#if __ASSUME_FACCESSAT2
+ return ret;
+#else
+ if (ret == 0 || errno != ENOSYS)
+ return ret;
+
if (flag & ~(AT_SYMLINK_NOFOLLOW | AT_EACCESS))
return INLINE_SYSCALL_ERROR_RETURN_VALUE (EINVAL);
@@ -41,9 +48,9 @@ faccessat (int fd, const char *file, int mode, int flag)
return -1;
mode &= (X_OK | W_OK | R_OK); /* Clear any bogus bits. */
-#if R_OK != S_IROTH || W_OK != S_IWOTH || X_OK != S_IXOTH
-# error Oops, portability assumptions incorrect.
-#endif
+# if R_OK != S_IROTH || W_OK != S_IWOTH || X_OK != S_IXOTH
+# error Oops, portability assumptions incorrect.
+# endif
if (mode == F_OK)
return 0; /* The file exists. */
@@ -68,4 +75,5 @@ faccessat (int fd, const char *file, int mode, int flag)
return 0;
return INLINE_SYSCALL_ERROR_RETURN_VALUE (EACCES);
+#endif /* !__ASSUME_FACCESSAT2 */
}
diff --git a/sysdeps/unix/sysv/linux/kernel-features.h b/sysdeps/unix/sysv/linux/kernel-features.h
index 32533e94cf..a6bbc3c94e 100644
--- a/sysdeps/unix/sysv/linux/kernel-features.h
+++ b/sysdeps/unix/sysv/linux/kernel-features.h
@@ -214,4 +214,12 @@
# define __ASSUME_WAITID_PID0_P_PGID
#endif
+/* The faccessat2 system call was introduced across all architectures
+ in Linux 5.8. */
+#if __LINUX_KERNEL_VERSION >= 0x050800
+# define __ASSUME_FACCESSAT2 1
+#else
+# define __ASSUME_FACCESSAT2 0
+#endif
+
#endif /* kernel-features.h */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-07 20:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-07 20:07 [glibc] Linux: Use faccessat2 to implement faccessat (bug 18683) Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).