public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] powerpc: Protect dl_powerpc_cpu_features on INIT_ARCH() [BZ #26615]
@ 2020-09-22 20:47 Tulio Magno Quites Machado Filho
  0 siblings, 0 replies; only message in thread
From: Tulio Magno Quites Machado Filho @ 2020-09-22 20:47 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3322ecbfe29a16e74c4f584d661b0b8018bb4031

commit 3322ecbfe29a16e74c4f584d661b0b8018bb4031
Author: Raphael Moreira Zinsly <rzinsly@linux.ibm.com>
Date:   Mon Sep 14 11:59:24 2020 -0300

    powerpc: Protect dl_powerpc_cpu_features on INIT_ARCH() [BZ #26615]
    
    dl_powerpc_cpu_features also needs to be protected by __GLRO to check
    for the _rtld_global_ro realocation before accessing it.
    
    Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>

Diff:
---
 sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h b/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
index 17ddfcf528..c8fa07fadc 100644
--- a/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
+++ b/sysdeps/powerpc/powerpc32/power4/multiarch/init-arch.h
@@ -38,7 +38,7 @@
   unsigned long int hwcap = __GLRO(dl_hwcap); 			\
   unsigned long int __attribute__((unused)) hwcap2 = __GLRO(dl_hwcap2); \
   bool __attribute__((unused)) use_cached_memopt =		\
-    GLRO(dl_powerpc_cpu_features).use_cached_memopt;		\
+    __GLRO(dl_powerpc_cpu_features.use_cached_memopt);		\
   if (hwcap & PPC_FEATURE_ARCH_2_06)				\
     hwcap |= PPC_FEATURE_ARCH_2_05 |				\
 	     PPC_FEATURE_POWER5_PLUS |				\


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-22 20:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 20:47 [glibc] powerpc: Protect dl_powerpc_cpu_features on INIT_ARCH() [BZ #26615] Tulio Magno Quites Machado Filho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).