public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Set locale related environment variables in debugglibc.sh
@ 2020-09-24 13:18 Arjun Shankar
  0 siblings, 0 replies; only message in thread
From: Arjun Shankar @ 2020-09-24 13:18 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b3b0b6916a2d4a966bbd852964054d475836c9eb

commit b3b0b6916a2d4a966bbd852964054d475836c9eb
Author: Arjun Shankar <arjun@redhat.com>
Date:   Thu Sep 24 14:58:36 2020 +0200

    Set locale related environment variables in debugglibc.sh
    
    Tests and binaries that use locale related functions need to run in the
    correct locale environment when being debugged via debugglibc.sh.  This
    commit sets up the environment, specifically: GCONV_PATH, LOCPATH, and
    LC_ALL for such tests and binaries when they are being debugged outside
    of a test container.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Diff:
---
 Makefile | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Makefile b/Makefile
index 6dcfe40c25..0fb5ffa128 100644
--- a/Makefile
+++ b/Makefile
@@ -305,6 +305,15 @@ then
   exit 1
 fi
 
+# Container tests needing locale data should install them in-container.
+# Other tests/binaries need to use locale data from the build tree.
+if [ "$$CONTAINER" = false ]
+then
+  ENVVARS="GCONV_PATH=$${BUILD_DIR}/iconvdata $$ENVVARS"
+  ENVVARS="LOCPATH=$${BUILD_DIR}/localedata $$ENVVARS"
+  ENVVARS="LC_ALL=C $$ENVVARS"
+fi
+
 # Expand environment setup command
 if [ -v ENVVARS ]
 then


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-24 13:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-24 13:18 [glibc] Set locale related environment variables in debugglibc.sh Arjun Shankar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).