[glibc/release/2.30/master] x86: Set header.feature_1 in TCB for always-on CET [BZ #27177]

[glibc/release/2.30/master] x86: Set header.feature_1 in TCB for always-on CET [BZ #27177]

[H.J. Lu]

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8113182a97182a691594c7db7dc04410081d5ae0

commit 8113182a97182a691594c7db7dc04410081d5ae0
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Jan 12 19:00:13 2021 -0800

    x86: Set header.feature_1 in TCB for always-on CET [BZ #27177]
    
    Update dl_cet_check() to set header.feature_1 in TCB when both IBT and
    SHSTK are always on.
    
    (cherry picked from commit 2ef23b520597f4ea1790a669b83e608f24f4cf12)

Diff:
---
 NEWS                         | 1 +
 sysdeps/x86/Makefile         | 6 ++++++
 sysdeps/x86/dl-cet.c         | 6 +++++-
 sysdeps/x86/tst-setjmp-cet.c | 1 +
 4 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 105fafb44c..06f475de97 100644
--- a/NEWS
+++ b/NEWS
@@ -58,6 +58,7 @@ The following bugs are resolved with this release:
   [25966] Incorrect access of __x86_shared_non_temporal_threshold for x32
   [25976] nss_compat: internal_end*ent may clobber errno, hiding ERANGE
   [27130] "rep movsb" performance issue
+  [27177] GLIBC_TUNABLES=glibc.cpu.x86_ibt=on:glibc.cpu.x86_shstk=on doesn't work
 
 \f
 Version 2.30
diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile
index 95182a508c..a5112ef367 100644
--- a/sysdeps/x86/Makefile
+++ b/sysdeps/x86/Makefile
@@ -12,6 +12,12 @@ endif
 ifeq ($(subdir),setjmp)
 gen-as-const-headers += jmp_buf-ssp.sym
 sysdep_routines += __longjmp_cancel
+ifneq ($(enable-cet),no)
+ifneq ($(have-tunables),no)
+tests += tst-setjmp-cet
+tst-setjmp-cet-ENV = GLIBC_TUNABLES=glibc.cpu.x86_ibt=on:glibc.cpu.x86_shstk=on
+endif
+endif
 endif
 
 ifeq ($(enable-cet),yes)
diff --git a/sysdeps/x86/dl-cet.c b/sysdeps/x86/dl-cet.c
index 4f70497aa7..2160263d4a 100644
--- a/sysdeps/x86/dl-cet.c
+++ b/sysdeps/x86/dl-cet.c
@@ -105,7 +105,11 @@ dl_cet_check (struct link_map *m, const char *program)
   /* No legacy object check if both IBT and SHSTK are always on.  */
   if (enable_ibt_type == CET_ALWAYS_ON
       && enable_shstk_type == CET_ALWAYS_ON)
-    return;
+    {
+      THREAD_SETMEM (THREAD_SELF, header.feature_1,
+		     GL(dl_x86_feature_1)[0]);
+      return;
+    }
 
   /* Check if IBT is enabled by kernel.  */
   bool ibt_enabled
diff --git a/sysdeps/x86/tst-setjmp-cet.c b/sysdeps/x86/tst-setjmp-cet.c
new file mode 100644
index 0000000000..42c795d2a8
--- /dev/null
+++ b/sysdeps/x86/tst-setjmp-cet.c
@@ -0,0 +1 @@
+#include <setjmp/tst-setjmp.c>