public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/grte_v5] Don't crash if /var/tmp doesn't exist
@ 2021-07-15 19:41 Shu-Chun Weng
  0 siblings, 0 replies; only message in thread
From: Shu-Chun Weng @ 2021-07-15 19:41 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=658b6ff7f04a0eae832c0b35adba889307ad924a

commit 658b6ff7f04a0eae832c0b35adba889307ad924a
Author: Shu-Chun Weng <scw@google.com>
Date:   Mon May 3 16:47:10 2021 -0700

    Don't crash if /var/tmp doesn't exist
    
    `xstat` is checked `stat64` crashing the program if the latter returns
    failure. In this loop, we are trying to find one folder that satisfies
    the condition, no reason to crash the program if one folder doesn't.

Diff:
---
 io/tst-copy_file_range.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/io/tst-copy_file_range.c b/io/tst-copy_file_range.c
index 3d531a1937..38763328d3 100644
--- a/io/tst-copy_file_range.c
+++ b/io/tst-copy_file_range.c
@@ -759,8 +759,7 @@ do_test (void)
           }
 
         struct stat64 cstat;
-        xstat (path, &cstat);
-        if (cstat.st_dev == instat.st_dev)
+        if (stat (path, &cstat) != 0 || cstat.st_dev == instat.st_dev)
           {
             free (to_free);
             continue;


^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-07-15 19:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 19:41 [glibc/grte_v5] Don't crash if /var/tmp doesn't exist Shu-Chun Weng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).