public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Make mcheck tests conditional on GLIBC_2.23 or earlier
@ 2021-07-22 13:11 Siddhesh Poyarekar
0 siblings, 0 replies; only message in thread
From: Siddhesh Poyarekar @ 2021-07-22 13:11 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0075c4f39dcc53025103e2919aa74b02f776c1d2
commit 0075c4f39dcc53025103e2919aa74b02f776c1d2
Author: Siddhesh Poyarekar <siddhesh@sourceware.org>
Date: Thu Jul 22 18:37:41 2021 +0530
Make mcheck tests conditional on GLIBC_2.23 or earlier
Targets with base versions of 2.24 or later won't have
__malloc_initialize_hook because of which the tests will essentially
be the same as the regular malloc tests. Avoid running them instead
and save time.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
Diff:
---
malloc/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/malloc/Makefile b/malloc/Makefile
index 918828e050..063d103d97 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -78,6 +78,8 @@ tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \
# Run all tests with MALLOC_CHECK_=3
tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests))
+# -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24.
+ifeq ($(have-GLIBC_2.23)$(build-shared),yesyes)
# Tests that don't play well with mcheck. They are either bugs in mcheck or
# the tests expect specific internal behavior that is changed due to linking to
# libmcheck.a.
@@ -100,6 +102,7 @@ tests-exclude-mcheck = tst-mallocstate \
tst-reallocarray
tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
+endif
routines = malloc morecore mcheck mtrace obstack reallocarray \
scratch_buffer_dupfree \
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-22 13:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 13:11 [glibc] Make mcheck tests conditional on GLIBC_2.23 or earlier Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).