public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/maskray/lld] [4/5] AArch64: Improve A64FX memset by removing unroll32
@ 2021-08-16 17:14 Fangrui Song
  0 siblings, 0 replies; only message in thread
From: Fangrui Song @ 2021-08-16 17:14 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e69d9981f858a38e19304e6ff5ebdf89f2cb0ba0

commit e69d9981f858a38e19304e6ff5ebdf89f2cb0ba0
Author: Wilco Dijkstra <wdijkstr@arm.com>
Date:   Tue Aug 10 13:44:27 2021 +0100

    [4/5] AArch64: Improve A64FX memset by removing unroll32
    
    Remove unroll32 code since it doesn't improve performance.
    
    Reviewed-by: Naohiro Tamura <naohirot@fujitsu.com>

Diff:
---
 sysdeps/aarch64/multiarch/memset_a64fx.S | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/sysdeps/aarch64/multiarch/memset_a64fx.S b/sysdeps/aarch64/multiarch/memset_a64fx.S
index 337c86be6f..ef0315658a 100644
--- a/sysdeps/aarch64/multiarch/memset_a64fx.S
+++ b/sysdeps/aarch64/multiarch/memset_a64fx.S
@@ -102,22 +102,6 @@ L(vl_agnostic): // VL Agnostic
 	ccmp	vector_length, tmp1, 0, cs
 	b.eq	L(L1_prefetch)
 
-L(unroll32):
-	lsl	tmp1, vector_length, 3	// vector_length * 8
-	lsl	tmp2, vector_length, 5	// vector_length * 32
-	.p2align 3
-1:	cmp	rest, tmp2
-	b.cc	L(unroll8)
-	st1b_unroll
-	add	dst, dst, tmp1
-	st1b_unroll
-	add	dst, dst, tmp1
-	st1b_unroll
-	add	dst, dst, tmp1
-	st1b_unroll
-	add	dst, dst, tmp1
-	sub	rest, rest, tmp2
-	b	1b
 
 L(unroll8):
 	lsl	tmp1, vector_length, 3
@@ -155,7 +139,7 @@ L(L1_prefetch): // if rest >= L1_SIZE
 	sub	rest, rest, CACHE_LINE_SIZE * 2
 	cmp	rest, L1_SIZE
 	b.ge	1b
-	cbnz	rest, L(unroll32)
+	cbnz	rest, L(unroll8)
 	ret
 
 	// count >= L2_SIZE


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-16 17:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 17:14 [glibc/maskray/lld] [4/5] AArch64: Improve A64FX memset by removing unroll32 Fangrui Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).