public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/maskray/grte] Disable non-opt error temporarily, and __sec_comment for clang
@ 2021-08-27 23:22 Fangrui Song
  0 siblings, 0 replies; only message in thread
From: Fangrui Song @ 2021-08-27 23:22 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9c0f7f13941775150435cbf2ed0777124329c6ff

commit 9c0f7f13941775150435cbf2ed0777124329c6ff
Author: Stan Shebs <stanshebs@google.com>
Date:   Mon Feb 26 13:50:53 2018 -0800

    Disable non-opt error temporarily, and __sec_comment for clang

Diff:
---
 include/libc-symbols.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index eb4dbbe777..c40f5fb6ca 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -71,9 +71,12 @@
 #define _LIBC	1
 
 /* Some files must be compiled with optimization on.  */
+/* This is a nuisance while experimenting; re-enable when done.  */
+#if 0
 #if !defined __ASSEMBLER__ && !defined __OPTIMIZE__
 # error "glibc cannot be compiled without optimization"
 #endif
+#endif
 
 /* -ffast-math cannot be applied to the C library, as it alters the ABI.
    Some test components that use -ffast-math are currently not part of
@@ -207,11 +210,16 @@
 
 /* Tacking on "\n\t#" to the section name makes gcc put it's bogus
    section attributes on what looks like a comment to the assembler.  */
+/* Clang sees newline and helpfully adds additional quotes; disable that.  */
+#if defined(__clang__)
+# define __sec_comment
+#else
 #ifdef HAVE_SECTION_QUOTES
 # define __sec_comment "\"\n\t#\""
 #else
 # define __sec_comment "\n\t#"
 #endif
+#endif
 #define link_warning(symbol, msg) \
   __make_section_unallocated (".gnu.warning." #symbol) \
   static const char __evoke_link_warning_##symbol[]	\


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-08-27 23:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 23:22 [glibc/maskray/grte] Disable non-opt error temporarily, and __sec_comment for clang Fangrui Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).