public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/maskray/grte] Do not use ppc-specific long double pack/unpack when compiling with clang
@ 2021-08-27 23:45 Fangrui Song
  0 siblings, 0 replies; 3+ messages in thread
From: Fangrui Song @ 2021-08-27 23:45 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=693e66f085f191d6aa180d97669671fec6d71a03

commit 693e66f085f191d6aa180d97669671fec6d71a03
Author: Stan Shebs <stanshebs@google.com>
Date:   Tue Jun 9 10:05:56 2020 -0700

    Do not use ppc-specific long double pack/unpack when compiling with clang

Diff:
---
 sysdeps/powerpc/fpu/math_ldbl.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sysdeps/powerpc/fpu/math_ldbl.h b/sysdeps/powerpc/fpu/math_ldbl.h
index 124391b94b..0867403d94 100644
--- a/sysdeps/powerpc/fpu/math_ldbl.h
+++ b/sysdeps/powerpc/fpu/math_ldbl.h
@@ -47,8 +47,13 @@ ldbl_unpack_ppc (long double l, double *a, double *aa)
   *aa = xl;
 }
 
+/* These inline functions do not work with clang at all; drop back to the
+   default versions.  (The defaults are not inlined by clang either, but they
+   return correct values at least.)*/
+#if !defined __clang__
 #define ldbl_pack   ldbl_pack_ppc
 #define ldbl_unpack ldbl_unpack_ppc
+#endif /* !__clang__ */
 
 #include <sysdeps/ieee754/ldbl-128ibm/math_ldbl.h>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [glibc/maskray/grte] Do not use ppc-specific long double pack/unpack when compiling with clang
@ 2021-08-28  0:33 Fangrui Song
  0 siblings, 0 replies; 3+ messages in thread
From: Fangrui Song @ 2021-08-28  0:33 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2c9e5207e426910c6c61c8bf3d31844b6f9aa0b1

commit 2c9e5207e426910c6c61c8bf3d31844b6f9aa0b1
Author: Stan Shebs <stanshebs@google.com>
Date:   Tue Jun 9 10:05:56 2020 -0700

    Do not use ppc-specific long double pack/unpack when compiling with clang

Diff:
---
 sysdeps/powerpc/fpu/math_ldbl.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sysdeps/powerpc/fpu/math_ldbl.h b/sysdeps/powerpc/fpu/math_ldbl.h
index 124391b94b..0867403d94 100644
--- a/sysdeps/powerpc/fpu/math_ldbl.h
+++ b/sysdeps/powerpc/fpu/math_ldbl.h
@@ -47,8 +47,13 @@ ldbl_unpack_ppc (long double l, double *a, double *aa)
   *aa = xl;
 }
 
+/* These inline functions do not work with clang at all; drop back to the
+   default versions.  (The defaults are not inlined by clang either, but they
+   return correct values at least.)*/
+#if !defined __clang__
 #define ldbl_pack   ldbl_pack_ppc
 #define ldbl_unpack ldbl_unpack_ppc
+#endif /* !__clang__ */
 
 #include <sysdeps/ieee754/ldbl-128ibm/math_ldbl.h>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [glibc/maskray/grte] Do not use ppc-specific long double pack/unpack when compiling with clang
@ 2021-08-28  0:29 Fangrui Song
  0 siblings, 0 replies; 3+ messages in thread
From: Fangrui Song @ 2021-08-28  0:29 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5149c184089bda310cf9b1ebb4425ad2dd7ed0b0

commit 5149c184089bda310cf9b1ebb4425ad2dd7ed0b0
Author: Stan Shebs <stanshebs@google.com>
Date:   Tue Jun 9 10:05:56 2020 -0700

    Do not use ppc-specific long double pack/unpack when compiling with clang

Diff:
---
 sysdeps/powerpc/fpu/math_ldbl.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sysdeps/powerpc/fpu/math_ldbl.h b/sysdeps/powerpc/fpu/math_ldbl.h
index 124391b94b..0867403d94 100644
--- a/sysdeps/powerpc/fpu/math_ldbl.h
+++ b/sysdeps/powerpc/fpu/math_ldbl.h
@@ -47,8 +47,13 @@ ldbl_unpack_ppc (long double l, double *a, double *aa)
   *aa = xl;
 }
 
+/* These inline functions do not work with clang at all; drop back to the
+   default versions.  (The defaults are not inlined by clang either, but they
+   return correct values at least.)*/
+#if !defined __clang__
 #define ldbl_pack   ldbl_pack_ppc
 #define ldbl_unpack ldbl_unpack_ppc
+#endif /* !__clang__ */
 
 #include <sysdeps/ieee754/ldbl-128ibm/math_ldbl.h>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-28  0:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 23:45 [glibc/maskray/grte] Do not use ppc-specific long double pack/unpack when compiling with clang Fangrui Song
2021-08-28  0:29 Fangrui Song
2021-08-28  0:33 Fangrui Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).