public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/maskray/clang] arm: Use internal symbol for _dl_argv on _dl_start_user
@ 2021-11-02 20:00 Fangrui Song
0 siblings, 0 replies; only message in thread
From: Fangrui Song @ 2021-11-02 20:00 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d6dea8c847a7fd053e94126dfbc920b9db0e0f97
commit d6dea8c847a7fd053e94126dfbc920b9db0e0f97
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Thu Oct 28 07:55:36 2021 -0300
arm: Use internal symbol for _dl_argv on _dl_start_user
The lld does not support R_ARM_GOTOFF32 to preemptible symbol (_dl_argv
has default visibility). Use the internal alias instead (one option
would to use HIDDEN_JUMPTARGET, bu the macro is not defined for
!__ASSEMBLER__ and I made this patch arm-specific to avoid require to
check extensivelly on other architecture it this might break something).
Checked on arm-linux-gnueabihf.
Reviewed-by: Fangrui Song <maskray@google.com>
Diff:
---
sysdeps/arm/dl-machine.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h
index c758bba169..4ecdde4355 100644
--- a/sysdeps/arm/dl-machine.h
+++ b/sysdeps/arm/dl-machine.h
@@ -202,7 +202,7 @@ _dl_start_user:\n\
.L_FINI_PROC:\n\
.word _dl_fini(GOTOFF)\n\
.L_ARGV:\n\
- .word _dl_argv(GOTOFF)\n\
+ .word __GI__dl_argv(GOTOFF)\n\
.L_LOADED:\n\
.word _rtld_local(GOTOFF)\n\
.previous\n\
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-11-02 20:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 20:00 [glibc/maskray/clang] arm: Use internal symbol for _dl_argv on _dl_start_user Fangrui Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).