public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
@ 2021-11-02 20:00 Fangrui Song
  0 siblings, 0 replies; 8+ messages in thread
From: Fangrui Song @ 2021-11-02 20:00 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bfdcdc544b607460da0fc403d5eeebe19776179d

commit bfdcdc544b607460da0fc403d5eeebe19776179d
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
@ 2021-11-03  7:41 Fangrui Song
  0 siblings, 0 replies; 8+ messages in thread
From: Fangrui Song @ 2021-11-03  7:41 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=aa2dedbaad2d8e6a61c56cb1d31265e79e5d88eb

commit aa2dedbaad2d8e6a61c56cb1d31265e79e5d88eb
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
@ 2021-10-20 21:24 Fangrui Song
  0 siblings, 0 replies; 8+ messages in thread
From: Fangrui Song @ 2021-10-20 21:24 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=dc1d47b5403c59d39c35383c8fa97ead601baa96

commit dc1d47b5403c59d39c35383c8fa97ead601baa96
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
@ 2021-10-19 17:02 Fangrui Song
  0 siblings, 0 replies; 8+ messages in thread
From: Fangrui Song @ 2021-10-19 17:02 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a32ad72a855209e5ed2817373d6c179ffa17d17b

commit a32ad72a855209e5ed2817373d6c179ffa17d17b
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
@ 2021-10-11 18:16 Fangrui Song
  0 siblings, 0 replies; 8+ messages in thread
From: Fangrui Song @ 2021-10-11 18:16 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c71bbcb392fa59f32a45c3fdfc342620486e3041

commit c71bbcb392fa59f32a45c3fdfc342620486e3041
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
@ 2021-10-10 23:12 Fangrui Song
  0 siblings, 0 replies; 8+ messages in thread
From: Fangrui Song @ 2021-10-10 23:12 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a372520f58b17671bd1da8c65ece3f84dd27d13e

commit a372520f58b17671bd1da8c65ece3f84dd27d13e
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
@ 2021-10-08  1:44 Fangrui Song
  0 siblings, 0 replies; 8+ messages in thread
From: Fangrui Song @ 2021-10-08  1:44 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0881bdfb9179f78b4fd254eeb33ab5b24c7a213d

commit 0881bdfb9179f78b4fd254eeb33ab5b24c7a213d
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname
@ 2021-10-07 20:13 Fangrui Song
  0 siblings, 0 replies; 8+ messages in thread
From: Fangrui Song @ 2021-10-07 20:13 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=90a723baa56122ed5845c559370b95f6f6796033

commit 90a723baa56122ed5845c559370b95f6f6796033
Author: Fangrui Song <maskray@google.com>
Date:   Sat Sep 25 18:50:02 2021 -0700

    libc-symbols.h: Work around asm label issues with #pragma redefine_extname
    
    Using asm labels can lead to `error: cannot apply asm label to function after its first use`
    in many places. `#pragma redefine_extname` has the same behavior with an asm label, but avoids the error.
    
    The symbol will not be properly renamed to a non-default version symbol.

Diff:
---
 include/libc-symbols.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index d41ecf4384..8a5a9ff0b3 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -534,9 +534,19 @@ for linking")
   __hidden_proto (name, , __GI_##name, ##attrs)
 #  define hidden_tls_proto(name, attrs...) \
   __hidden_proto (name, __thread, __GI_##name, ##attrs)
-#  define __hidden_proto(name, thread, internal, attrs...)	     \
+#  ifdef __clang__
+#   define __hidden_proto(name, thread, internal, attrs...)           \
+      extern thread __typeof (name) name \
+      __hidden_proto_hiddenattr (attrs); \
+      _Pragma (__redefine(name, internal))
+/* Note that this macro does not use __hidden_asmname, since it produces a string.  */
+#   define __redefine(name, internal) __stringize(redefine_extname name internal)
+#   define __stringize(X) #X
+#  else
+#   define __hidden_proto(name, thread, internal, attrs...)	     \
   extern thread __typeof (name) name __asm__ (__hidden_asmname (#internal)) \
   __hidden_proto_hiddenattr (attrs);
+#  endif
 #  define __hidden_asmname(name) \
   __hidden_asmname1 (__USER_LABEL_PREFIX__, name)
 #  define __hidden_asmname1(prefix, name) __hidden_asmname2(prefix, name)


^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-11-03  7:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 20:00 [glibc/maskray/clang] libc-symbols.h: Work around asm label issues with #pragma redefine_extname Fangrui Song
  -- strict thread matches above, loose matches on Subject: below --
2021-11-03  7:41 Fangrui Song
2021-10-20 21:24 Fangrui Song
2021-10-19 17:02 Fangrui Song
2021-10-11 18:16 Fangrui Song
2021-10-10 23:12 Fangrui Song
2021-10-08  1:44 Fangrui Song
2021-10-07 20:13 Fangrui Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).