public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] x86-64: Replace movzx with movzbl
@ 2021-11-03  3:59 Fangrui Song
  0 siblings, 0 replies; only message in thread
From: Fangrui Song @ 2021-11-03  3:59 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6720d36b6623c5e48c070d86acf61198b33e144e

commit 6720d36b6623c5e48c070d86acf61198b33e144e
Author: Fangrui Song <maskray@google.com>
Date:   Tue Nov 2 20:59:52 2021 -0700

    x86-64: Replace movzx with movzbl
    
    Clang cannot assemble movzx in the AT&T dialect mode.
    
    ../sysdeps/x86_64/strcmp.S:2232:16: error: invalid operand for instruction
     movzx (%rsi), %ecx
                   ^~~~
    
    Change movzx to movzbl, which follows the AT&T dialect and is used
    elsewhere in the file.
    
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Diff:
---
 sysdeps/x86_64/multiarch/strcmp-sse42.S | 4 ++--
 sysdeps/x86_64/strcmp.S                 | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
index 617d3a3946..be1ddb3f92 100644
--- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
+++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
@@ -1770,8 +1770,8 @@ LABEL(strcmp_exitz):
 	.p2align 4
 	// XXX Same as code above
 LABEL(Byte0):
-	movzx	(%rsi), %ecx
-	movzx	(%rdi), %eax
+	movzbl	(%rsi), %ecx
+	movzbl	(%rdi), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 	leaq	_nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx
diff --git a/sysdeps/x86_64/strcmp.S b/sysdeps/x86_64/strcmp.S
index c7cbe4042a..bfe83abede 100644
--- a/sysdeps/x86_64/strcmp.S
+++ b/sysdeps/x86_64/strcmp.S
@@ -2229,8 +2229,8 @@ LABEL(strcmp_exitz):
 
 	.p2align 4
 LABEL(Byte0):
-	movzx	(%rsi), %ecx
-	movzx	(%rdi), %eax
+	movzbl	(%rsi), %ecx
+	movzbl	(%rdi), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 	leaq	_nl_C_LC_CTYPE_tolower+128*4(%rip), %rdx


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-03  3:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-03  3:59 [glibc] x86-64: Replace movzx with movzbl Fangrui Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).