public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug 28732)
@ 2022-01-17  9:20 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2022-01-17  9:20 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=06200aac9bec34dbcac28b8c60e49a77e7851c1f

commit 06200aac9bec34dbcac28b8c60e49a77e7851c1f
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon Jan 17 09:57:19 2022 +0100

    elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug 28732)
    
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Diff:
---
 elf/tst-dl_find_object.c | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/elf/tst-dl_find_object.c b/elf/tst-dl_find_object.c
index 855d0fc735..6d2a2ffd1c 100644
--- a/elf/tst-dl_find_object.c
+++ b/elf/tst-dl_find_object.c
@@ -71,19 +71,24 @@ check (void *address,
               __FILE__, line, address,
               actual.dlfo_flags, expected->dlfo_flags);
     }
-  if (actual.dlfo_flags != expected->dlfo_flags)
+  if (expected->dlfo_link_map->l_contiguous)
     {
-      support_record_failure ();
-      printf ("%s:%d: error: %p: map start is %p, expected %p\n",
-              __FILE__, line,
-              address, actual.dlfo_map_start, expected->dlfo_map_start);
-    }
-  if (actual.dlfo_map_end != expected->dlfo_map_end)
-    {
-      support_record_failure ();
-      printf ("%s:%d: error: %p: map end is %p, expected %p\n",
-              __FILE__, line,
-              address, actual.dlfo_map_end, expected->dlfo_map_end);
+      /* If the mappings are not contiguous, the actual and execpted
+         mappings may differ, so this subtest will not work.  */
+      if (actual.dlfo_flags != expected->dlfo_flags)
+        {
+          support_record_failure ();
+          printf ("%s:%d: error: %p: map start is %p, expected %p\n",
+                  __FILE__, line,
+                  address, actual.dlfo_map_start, expected->dlfo_map_start);
+        }
+      if (actual.dlfo_map_end != expected->dlfo_map_end)
+        {
+          support_record_failure ();
+          printf ("%s:%d: error: %p: map end is %p, expected %p\n",
+                  __FILE__, line,
+                  address, actual.dlfo_map_end, expected->dlfo_map_end);
+        }
     }
   if (actual.dlfo_link_map != expected->dlfo_link_map)
     {


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-17  9:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17  9:20 [glibc] elf/tst-dl_find_object: Disable subtests for non-contiguous maps (bug 28732) Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).