public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/release/2.29/master] test-container: Install with $(all-subdirs) [BZ #24794]
@ 2022-01-27 15:28 H.J. Lu
  0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2022-01-27 15:28 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=edceb7f52045931035018fa89824fd5d7a8c875c

commit edceb7f52045931035018fa89824fd5d7a8c875c
Author: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Date:   Mon Jul 22 17:34:13 2019 -0300

    test-container: Install with $(all-subdirs) [BZ #24794]
    
    Whenever a sub-make is created, it inherits the variable subdirs from its
    parent.  This is also true when make check is called with a restricted
    list of subdirs.  In this scenario, make install is executed "partially"
    and testroot.pristine ends up with an incomplete installation.
    
            [BZ #24794]
            * Makefile (testroot.pristine/install.stamp): Pass
            subdirs='$(all-subdirs)' to make install.
    
    Reviewed-by: DJ Delorie <dj@redhat.com>
    (cherry picked from commit 35e038c1d2ccb3a75395662f9c4f28d85a61444f)

Diff:
---
 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 4a014d6eff..723aa0e456 100644
--- a/Makefile
+++ b/Makefile
@@ -395,7 +395,8 @@ ifeq ($(run-built-tests),yes)
 	    $(test-wrapper) cp $$dso $(objpfx)testroot.pristine$$dso ;\
 	  done
 endif
-	$(MAKE) install DESTDIR=$(objpfx)testroot.pristine
+	$(MAKE) install DESTDIR=$(objpfx)testroot.pristine \
+	  subdirs='$(all-subdirs)'
 	touch $(objpfx)testroot.pristine/install.stamp
 
 tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-27 15:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 15:28 [glibc/release/2.29/master] test-container: Install with $(all-subdirs) [BZ #24794] H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).