public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/release/2.33/master] socket: Do not use AF_NETLINK in __opensock
@ 2022-02-03 19:29 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2022-02-03 19:29 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=55446dd8a2d7b84d966fe4248427c02845b036d4

commit 55446dd8a2d7b84d966fe4248427c02845b036d4
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon Nov 22 14:41:14 2021 +0100

    socket: Do not use AF_NETLINK in __opensock
    
    It is not possible to use interface ioctls with netlink sockets
    on all Linux kernels.
    
    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
    (cherry picked from commit 3d981795cd00cc9b73c3ee5087c308361acd62e5)

Diff:
---
 socket/opensock.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/socket/opensock.c b/socket/opensock.c
index ff94d27a61..3e35821f91 100644
--- a/socket/opensock.c
+++ b/socket/opensock.c
@@ -24,17 +24,10 @@
 int
 __opensock (void)
 {
-  /* SOCK_DGRAM is supported by all address families.  (Netlink does
-     not support SOCK_STREAM.)  */
+  /* SOCK_DGRAM is supported by all address families.  */
   int type = SOCK_DGRAM | SOCK_CLOEXEC;
   int fd;
 
-#ifdef AF_NETLINK
-  fd = __socket (AF_NETLINK, type, 0);
-  if (fd >= 0)
-    return fd;
-#endif
-
   fd = __socket (AF_UNIX, type, 0);
   if (fd >= 0)
     return fd;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-03 19:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-03 19:29 [glibc/release/2.33/master] socket: Do not use AF_NETLINK in __opensock Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).