public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Noah Goldstein <nwg@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] Benchtests: move 'alloc_bufs' from loop in bench-memset.c
Date: Sat,  5 Feb 2022 22:58:40 +0000 (GMT)	[thread overview]
Message-ID: <20220205225840.E07A33858412@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=90cbb806361a5da29a9ef99866f0b3e699fad176

commit 90cbb806361a5da29a9ef99866f0b3e699fad176
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Sat Feb 5 03:10:44 2022 -0600

    Benchtests: move 'alloc_bufs' from loop in bench-memset.c
    
    One buf allocation is sufficient. Calling `alloc_bufs' in the loop
    just adds unnecessary syscall overhead.
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Diff:
---
 benchtests/bench-memset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
index beba3fbe46..e1e2d5f176 100644
--- a/benchtests/bench-memset.c
+++ b/benchtests/bench-memset.c
@@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len)
   FOR_EACH_IMPL (impl, 0)
     {
       do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len);
-      alloc_bufs ();
     }
 
   json_array_end (json_ctx);
@@ -88,8 +87,9 @@ test_main (void)
   size_t i;
   int c = 0;
 
-  test_init ();
 
+  test_init ();
+  alloc_bufs ();
   json_init (&json_ctx, 0, stdout);
 
   json_document_begin (&json_ctx);


                 reply	other threads:[~2022-02-05 22:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220205225840.E07A33858412@sourceware.org \
    --to=nwg@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).