public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] Benchtests: move 'alloc_bufs' from loop in bench-memset.c
@ 2022-02-05 22:58 Noah Goldstein
  0 siblings, 0 replies; only message in thread
From: Noah Goldstein @ 2022-02-05 22:58 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=90cbb806361a5da29a9ef99866f0b3e699fad176

commit 90cbb806361a5da29a9ef99866f0b3e699fad176
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Sat Feb 5 03:10:44 2022 -0600

    Benchtests: move 'alloc_bufs' from loop in bench-memset.c
    
    One buf allocation is sufficient. Calling `alloc_bufs' in the loop
    just adds unnecessary syscall overhead.
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Diff:
---
 benchtests/bench-memset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
index beba3fbe46..e1e2d5f176 100644
--- a/benchtests/bench-memset.c
+++ b/benchtests/bench-memset.c
@@ -74,7 +74,6 @@ do_test (json_ctx_t *json_ctx, size_t align, int c, size_t len)
   FOR_EACH_IMPL (impl, 0)
     {
       do_one_test (json_ctx, impl, (CHAR *) (buf1) + align, c, len);
-      alloc_bufs ();
     }
 
   json_array_end (json_ctx);
@@ -88,8 +87,9 @@ test_main (void)
   size_t i;
   int c = 0;
 
-  test_init ();
 
+  test_init ();
+  alloc_bufs ();
   json_init (&json_ctx, 0, stdout);
 
   json_document_begin (&json_ctx);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-05 22:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-05 22:58 [glibc] Benchtests: move 'alloc_bufs' from loop in bench-memset.c Noah Goldstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).