public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: John David Anglin <danglin@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/release/2.33/master] nptl: Fix cleanups for stack grows up [BZ# 28899]
Date: Tue,  8 Mar 2022 13:34:47 +0000 (GMT)	[thread overview]
Message-ID: <20220308133447.BD33A385C40B@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6d9525b620eac4cbdf790baf4776e85cf08df7c5

commit 6d9525b620eac4cbdf790baf4776e85cf08df7c5
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Mon Feb 28 15:47:38 2022 +0000

    nptl: Fix cleanups for stack grows up [BZ# 28899]
    
    _STACK_GROWS_DOWN is defined to 0 when the stack grows up.  The
    code in unwind.c used `#ifdef _STACK_GROWS_DOWN' to selct the
    stack grows down define for FRAME_LEFT.  As a result, the
    _STACK_GROWS_DOWN define was always selected and cleanups were
    incorrectly sequenced when the stack grows up.
    
    (cherry picked from commit 2bbc694df279020a6620096d31c1e05c93966f9b)

Diff:
---
 nptl/unwind.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nptl/unwind.c b/nptl/unwind.c
index 9c7ed7d7ca..0a2ec9b8bb 100644
--- a/nptl/unwind.c
+++ b/nptl/unwind.c
@@ -26,7 +26,7 @@
 #include <libc-diag.h>
 #include <jmpbuf-unwind.h>
 
-#ifdef _STACK_GROWS_DOWN
+#if _STACK_GROWS_DOWN
 # define FRAME_LEFT(frame, other, adj) \
   ((uintptr_t) frame - adj >= (uintptr_t) other - adj)
 #elif _STACK_GROWS_UP


                 reply	other threads:[~2022-03-08 13:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220308133447.BD33A385C40B@sourceware.org \
    --to=danglin@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).