public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/release/2.33/master] nptl: Fix cleanups for stack grows up [BZ# 28899]
@ 2022-03-08 13:34 John David Anglin
  0 siblings, 0 replies; only message in thread
From: John David Anglin @ 2022-03-08 13:34 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6d9525b620eac4cbdf790baf4776e85cf08df7c5

commit 6d9525b620eac4cbdf790baf4776e85cf08df7c5
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Mon Feb 28 15:47:38 2022 +0000

    nptl: Fix cleanups for stack grows up [BZ# 28899]
    
    _STACK_GROWS_DOWN is defined to 0 when the stack grows up.  The
    code in unwind.c used `#ifdef _STACK_GROWS_DOWN' to selct the
    stack grows down define for FRAME_LEFT.  As a result, the
    _STACK_GROWS_DOWN define was always selected and cleanups were
    incorrectly sequenced when the stack grows up.
    
    (cherry picked from commit 2bbc694df279020a6620096d31c1e05c93966f9b)

Diff:
---
 nptl/unwind.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nptl/unwind.c b/nptl/unwind.c
index 9c7ed7d7ca..0a2ec9b8bb 100644
--- a/nptl/unwind.c
+++ b/nptl/unwind.c
@@ -26,7 +26,7 @@
 #include <libc-diag.h>
 #include <jmpbuf-unwind.h>
 
-#ifdef _STACK_GROWS_DOWN
+#if _STACK_GROWS_DOWN
 # define FRAME_LEFT(frame, other, adj) \
   ((uintptr_t) frame - adj >= (uintptr_t) other - adj)
 #elif _STACK_GROWS_UP


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-03-08 13:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08 13:34 [glibc/release/2.33/master] nptl: Fix cleanups for stack grows up [BZ# 28899] John David Anglin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).