public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] benchtests: make compare_strings.py accept string as attribute value
Date: Tue,  8 Mar 2022 14:18:00 +0000 (GMT)	[thread overview]
Message-ID: <20220308141800.98FBA385C415@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=edddffc9df5ea5882192bca7ddaad8f6440bcc44

commit edddffc9df5ea5882192bca7ddaad8f6440bcc44
Author: Su Lifan <su-lifan@linux.alibaba.com>
Date:   Fri Feb 25 16:58:07 2022 +0800

    benchtests: make compare_strings.py accept string as attribute value
    
    Commit ac759b1fbf28a82d99afde9046f8b72c7cba5dae added attribute
    "overlap" to bench-memmove-walk, whose value is a string. This change
    makes compare_strings.py fail since benchout_strings.schema.json
    requires the values of attributes to be number.
    
    This patch relaxes such constraint.
    Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Diff:
---
 benchtests/scripts/benchout_strings.schema.json | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/benchtests/scripts/benchout_strings.schema.json b/benchtests/scripts/benchout_strings.schema.json
index 7c9a67134b..bfd9b4e6c0 100644
--- a/benchtests/scripts/benchout_strings.schema.json
+++ b/benchtests/scripts/benchout_strings.schema.json
@@ -28,7 +28,12 @@
 		    "items": {"type": "number"}
                    }
 		 },
-		 "additionalProperties": {"type": "number"},
+		 "additionalProperties": {
+		   "oneOf": [
+		     { "type": "number" },
+		     { "type": "string" }
+		   ]
+		 },
 		 "minProperties": 2
 	      }
 	    }


                 reply	other threads:[~2022-03-08 14:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220308141800.98FBA385C415@sourceware.org \
    --to=siddhesh@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).