public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] benchtests: make compare_strings.py accept string as attribute value
@ 2022-03-08 14:18 Siddhesh Poyarekar
  0 siblings, 0 replies; only message in thread
From: Siddhesh Poyarekar @ 2022-03-08 14:18 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=edddffc9df5ea5882192bca7ddaad8f6440bcc44

commit edddffc9df5ea5882192bca7ddaad8f6440bcc44
Author: Su Lifan <su-lifan@linux.alibaba.com>
Date:   Fri Feb 25 16:58:07 2022 +0800

    benchtests: make compare_strings.py accept string as attribute value
    
    Commit ac759b1fbf28a82d99afde9046f8b72c7cba5dae added attribute
    "overlap" to bench-memmove-walk, whose value is a string. This change
    makes compare_strings.py fail since benchout_strings.schema.json
    requires the values of attributes to be number.
    
    This patch relaxes such constraint.
    Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

Diff:
---
 benchtests/scripts/benchout_strings.schema.json | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/benchtests/scripts/benchout_strings.schema.json b/benchtests/scripts/benchout_strings.schema.json
index 7c9a67134b..bfd9b4e6c0 100644
--- a/benchtests/scripts/benchout_strings.schema.json
+++ b/benchtests/scripts/benchout_strings.schema.json
@@ -28,7 +28,12 @@
 		    "items": {"type": "number"}
                    }
 		 },
-		 "additionalProperties": {"type": "number"},
+		 "additionalProperties": {
+		   "oneOf": [
+		     { "type": "number" },
+		     { "type": "string" }
+		   ]
+		 },
 		 "minProperties": 2
 	      }
 	    }


^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2022-03-08 14:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08 14:18 [glibc] benchtests: make compare_strings.py accept string as attribute value Siddhesh Poyarekar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).