public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: H.J. Lu <hjl@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] benchtests: Use "=" instead of ":=" [BZ #28970]
Date: Wed, 16 Mar 2022 15:48:51 +0000 (GMT)	[thread overview]
Message-ID: <20220316154851.9D19D386549C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=564f7ae7b45ee00e8e35499e462d28ad45c56022

commit 564f7ae7b45ee00e8e35499e462d28ad45c56022
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Mar 16 08:43:48 2022 -0700

    benchtests: Use "=" instead of ":=" [BZ #28970]
    
    Use "=" instead of ":=" to allow sysdeps Makefiles to add more benches
    to bench and benchset.  This fixes BZ #28970.
    Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>

Diff:
---
 benchtests/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/benchtests/Makefile b/benchtests/Makefile
index d513b29903..8dfca592fd 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -296,9 +296,11 @@ bench-extra-objs = json-lib.o
 extra-objs += $(bench-extra-objs)
 others-extras = $(bench-extra-objs)
 
-binaries-bench := $(addprefix $(objpfx)bench-,$(bench))
+# NB: Use "=" instead of ":=" since sysdeps Makefiles may add more
+# benches.
+binaries-bench = $(addprefix $(objpfx)bench-,$(bench))
 extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench)))
-binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset))
+binaries-benchset = $(addprefix $(objpfx)bench-,$(benchset))
 extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset)))
 binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc))
 extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc)))


                 reply	other threads:[~2022-03-16 15:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220316154851.9D19D386549C@sourceware.org \
    --to=hjl@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).