public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] benchtests: Use "=" instead of ":=" [BZ #28970]
@ 2022-03-16 15:48 H.J. Lu
0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2022-03-16 15:48 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=564f7ae7b45ee00e8e35499e462d28ad45c56022
commit 564f7ae7b45ee00e8e35499e462d28ad45c56022
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Wed Mar 16 08:43:48 2022 -0700
benchtests: Use "=" instead of ":=" [BZ #28970]
Use "=" instead of ":=" to allow sysdeps Makefiles to add more benches
to bench and benchset. This fixes BZ #28970.
Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>
Diff:
---
benchtests/Makefile | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/benchtests/Makefile b/benchtests/Makefile
index d513b29903..8dfca592fd 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -296,9 +296,11 @@ bench-extra-objs = json-lib.o
extra-objs += $(bench-extra-objs)
others-extras = $(bench-extra-objs)
-binaries-bench := $(addprefix $(objpfx)bench-,$(bench))
+# NB: Use "=" instead of ":=" since sysdeps Makefiles may add more
+# benches.
+binaries-bench = $(addprefix $(objpfx)bench-,$(bench))
extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench)))
-binaries-benchset := $(addprefix $(objpfx)bench-,$(benchset))
+binaries-benchset = $(addprefix $(objpfx)bench-,$(benchset))
extra-objs += $(addsuffix .o,$(addprefix bench-,$(benchset)))
binaries-bench-malloc := $(addprefix $(objpfx)bench-,$(bench-malloc))
extra-objs += $(addsuffix .o,$(addprefix bench-,$(bench-malloc)))
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-03-16 15:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 15:48 [glibc] benchtests: Use "=" instead of ":=" [BZ #28970] H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).