public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/ibm/2.32/master] test-strnlen.c: Check that strnlen won't go beyond the maximum length
@ 2022-04-01 20:06 Raoni Fassina Firmino
  0 siblings, 0 replies; only message in thread
From: Raoni Fassina Firmino @ 2022-04-01 20:06 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=33046deb9626e35b587db9e722111a450f952e44

commit 33046deb9626e35b587db9e722111a450f952e44
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Mar 27 09:06:39 2021 -0700

    test-strnlen.c: Check that strnlen won't go beyond the maximum length
    
    Place strings ending at page boundary without the null byte.  If an
    implementation goes beyond EXP_LEN, it will trigger the segfault.
    
    (cherry picked from commit cb882b21b63606aabd6e55afe23b42434d95f2ef)

Diff:
---
 string/test-strnlen.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/string/test-strnlen.c b/string/test-strnlen.c
index 2a56d16c17..9b4b01a1a7 100644
--- a/string/test-strnlen.c
+++ b/string/test-strnlen.c
@@ -198,6 +198,35 @@ do_page_tests (void)
     }
 }
 
+/* Tests meant to unveil fail on implementations that access bytes
+   beyond the maxium length.  */
+
+static void
+do_page_2_tests (void)
+{
+  size_t i, exp_len, offset;
+  size_t last_offset = page_size / sizeof (CHAR);
+
+  CHAR *s = (CHAR *) buf2;
+  MEMSET (s, 65, last_offset);
+
+  /* Place short strings ending at page boundary without the null
+     byte.  */
+  offset = last_offset;
+  for (i = 0; i < 128; i++)
+    {
+      /* Decrease offset to stress several sizes and alignments.  */
+      offset--;
+      exp_len = last_offset - offset;
+      FOR_EACH_IMPL (impl, 0)
+	{
+	  /* If an implementation goes beyond EXP_LEN, it will trigger
+	     the segfault.  */
+	  do_one_test (impl, (CHAR *) (s + offset), exp_len, exp_len);
+	}
+    }
+}
+
 int
 test_main (void)
 {
@@ -244,6 +273,7 @@ test_main (void)
 
   do_random_tests ();
   do_page_tests ();
+  do_page_2_tests ();
   return ret;
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-01 20:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-01 20:06 [glibc/ibm/2.32/master] test-strnlen.c: Check that strnlen won't go beyond the maximum length Raoni Fassina Firmino

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).