public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] S390: Fix elf/tst-audit25[ab]
@ 2022-04-07 18:38 Stefan Liebler
  0 siblings, 0 replies; only message in thread
From: Stefan Liebler @ 2022-04-07 18:38 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5325233313c66aea13e86f5dd59618e9dd74b510

commit 5325233313c66aea13e86f5dd59618e9dd74b510
Author: Stefan Liebler <stli@linux.ibm.com>
Date:   Thu Apr 7 13:59:48 2022 +0200

    S390: Fix elf/tst-audit25[ab]
    
    If glibc is configured with --disable-default-pie and build on
    s390 with -O3, the tests elf/tst-audit25a and elf/tst-audit25b are
    failing as there are additional la_symbind lines for free and malloc.
    It turns out that those belong to the executable. In fact those are
    the PLT-stubs. Furthermore la_symbind is also called for calloc and
    realloc symbols, but those belong to libc.
    
    Those functions are not called at all, but dlsym'ed in
    elf/dl-minimal.c:
    __rtld_malloc_init_real (struct link_map *main_map)
    {
    ...
      void *new_calloc = lookup_malloc_symbol (main_map, "calloc", &version);
      void *new_free = lookup_malloc_symbol (main_map, "free", &version);
      void *new_malloc = lookup_malloc_symbol (main_map, "malloc", &version);
      void *new_realloc = lookup_malloc_symbol (main_map, "realloc", &version);
    ...
    }
    
    Therefore, this commit just ignored symbols with LA_SYMB_DLSYM flag.
    Reviewed-by: Adheemrval Zanella  <adhemerval.zanella@linaro.org>

Diff:
---
 elf/tst-auditmod25.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/elf/tst-auditmod25.c b/elf/tst-auditmod25.c
index 20640a8daf..0524c5aab1 100644
--- a/elf/tst-auditmod25.c
+++ b/elf/tst-auditmod25.c
@@ -72,7 +72,8 @@ la_symbind32 (Elf32_Sym *sym, unsigned int ndx,
 	      unsigned int *flags, const char *symname)
 #endif
 {
-  if (*refcook != -1 && *defcook != -1 && symname[0] != '\0')
+  if (*refcook != -1 && *defcook != -1 && symname[0] != '\0'
+      && (*flags & LA_SYMB_DLSYM) == 0)
     fprintf (stderr, "la_symbind: %s %u\n", symname,
 	     *flags & (LA_SYMB_NOPLTENTER | LA_SYMB_NOPLTEXIT) ? 1 : 0);
   return sym->st_value;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-07 18:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 18:38 [glibc] S390: Fix elf/tst-audit25[ab] Stefan Liebler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).