public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] manual: Avoid name collision in libm ULP table [BZ #28956]
@ 2022-04-11 15:46 Carlos O'Donell
0 siblings, 0 replies; only message in thread
From: Carlos O'Donell @ 2022-04-11 15:46 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d2265570a7694b5b01d5a0a2d56d3482ac1a5d97
commit d2265570a7694b5b01d5a0a2d56d3482ac1a5d97
Author: Tom Coldrick <thomas.coldrick@codethink.co.uk>
Date: Tue Apr 5 10:46:54 2022 +0100
manual: Avoid name collision in libm ULP table [BZ #28956]
The 32-bit and 64-bit variants of RISC-V share the same name - "RISC-V"
- when generating the libm error table for the info pages. This
collision, and the way how the table is generated, mean that the values
in the final table for "RISC-V" may be either for the 32- or 64-bit
variant, with no indication as to which.
As an additional side-effect, this makes the build non-reproducible, as
the error table generated is dependent upon the host filesystem
implementation.
To solve this issue, the libm-test-ulps-name files for both variants
have been modified to include their word size, so as to remove the
collision and provide more accurate information in the table.
An alternative proposed was to merge the two variants' ULP values into a
single file, but this would mean that information about error values is
lost, as the two variants are not identical. Some differences are
considerable, notably the values for the exp() function are large.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
Diff:
---
sysdeps/riscv/rv32/rvd/libm-test-ulps-name | 2 +-
sysdeps/riscv/rv64/rvd/libm-test-ulps-name | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sysdeps/riscv/rv32/rvd/libm-test-ulps-name b/sysdeps/riscv/rv32/rvd/libm-test-ulps-name
index 827fcdca19..6d2816082e 100644
--- a/sysdeps/riscv/rv32/rvd/libm-test-ulps-name
+++ b/sysdeps/riscv/rv32/rvd/libm-test-ulps-name
@@ -1 +1 @@
-RISC-V
+RISC-V 32-bit
diff --git a/sysdeps/riscv/rv64/rvd/libm-test-ulps-name b/sysdeps/riscv/rv64/rvd/libm-test-ulps-name
index 827fcdca19..9cb50380df 100644
--- a/sysdeps/riscv/rv64/rvd/libm-test-ulps-name
+++ b/sysdeps/riscv/rv64/rvd/libm-test-ulps-name
@@ -1 +1 @@
-RISC-V
+RISC-V 64-bit
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-04-11 15:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 15:46 [glibc] manual: Avoid name collision in libm ULP table [BZ #28956] Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).