public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] test-container: Fix "unused code" warnings on HURD
@ 2022-04-11 23:28 Samuel Thibault
  0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2022-04-11 23:28 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d2263bf50af9aab84210c8c9bbf100bd780efad9

commit d2263bf50af9aab84210c8c9bbf100bd780efad9
Author: DJ Delorie <dj@redhat.com>
Date:   Mon Apr 11 15:45:35 2022 -0400

    test-container: Fix "unused code" warnings on HURD
    
    Comment out bits of code that are only used when we *have* pid
    namespaces, to avoid "unused code" warnings.
    
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    
    Message-Id: <xno817tnds.fsf@greed.delorie.com>

Diff:
---
 support/test-container.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/support/test-container.c b/support/test-container.c
index c837c4d758..7557aac441 100644
--- a/support/test-container.c
+++ b/support/test-container.c
@@ -230,6 +230,7 @@ concat (const char *str, ...)
   return bufs[n];
 }
 
+#ifdef CLONE_NEWNS
 /* Like the above, but put spaces between words.  Caller frees.  */
 static char *
 concat_words (char **words, int num_words)
@@ -255,6 +256,7 @@ concat_words (char **words, int num_words)
 
   return rv;
 }
+#endif
 
 /* Try to mount SRC onto DEST.  */
 static void
@@ -756,7 +758,9 @@ main (int argc, char **argv)
   /* If set, the test runs as root instead of the user running the testsuite.  */
   int be_su = 0;
   int require_pidns = 0;
+#ifdef CLONE_NEWNS
   const char *pidns_comment = NULL;
+#endif
   int do_proc_mounts = 0;
   int UMAP;
   int GMAP;
@@ -1046,8 +1050,10 @@ main (int argc, char **argv)
 	    else if (nt >= 1 && strcmp (the_words[0], "pidns") == 0)
 	      {
 		require_pidns = 1;
+#ifdef CLONE_NEWNS
 		if (nt > 1)
 		  pidns_comment = concat_words (the_words + 1, nt - 1);
+#endif
 	      }
 	    else if (nt == 3 && strcmp (the_words[0], "mkdirp") == 0)
 	      {


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-11 23:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 23:28 [glibc] test-container: Fix "unused code" warnings on HURD Samuel Thibault

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).