public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/release/2.34/master] x86: Remove SSSE3 instruction for broadcast in memset.S (SSE2 Only)
@ 2022-05-05 16:41 Sunil Pandey
  0 siblings, 0 replies; only message in thread
From: Sunil Pandey @ 2022-05-05 16:41 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=190ea5f7e4e7e98b9b6e3f29835ae8b1f6a5442e

commit 190ea5f7e4e7e98b9b6e3f29835ae8b1f6a5442e
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Mon Feb 7 00:32:23 2022 -0600

    x86: Remove SSSE3 instruction for broadcast in memset.S (SSE2 Only)
    
    commit b62ace2740a106222e124cc86956448fa07abf4d
    Author: Noah Goldstein <goldstein.w.n@gmail.com>
    Date:   Sun Feb 6 00:54:18 2022 -0600
    
        x86: Improve vec generation in memset-vec-unaligned-erms.S
    
    Revert usage of 'pshufb' in broadcast logic as it is an SSSE3
    instruction and memset.S is restricted to only SSE2 instructions.
    
    (cherry picked from commit 1b0c60f95bbe2eded80b2bb5be75c0e45b11cde1)

Diff:
---
 sysdeps/x86_64/memset.S | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sysdeps/x86_64/memset.S b/sysdeps/x86_64/memset.S
index 34ee0bfdcb..954471e5a5 100644
--- a/sysdeps/x86_64/memset.S
+++ b/sysdeps/x86_64/memset.S
@@ -30,9 +30,10 @@
 
 # define MEMSET_SET_VEC0_AND_SET_RETURN(d, r) \
   movd d, %xmm0; \
-  pxor %xmm1, %xmm1; \
-  pshufb %xmm1, %xmm0; \
-  movq r, %rax
+  movq r, %rax; \
+  punpcklbw %xmm0, %xmm0; \
+  punpcklwd %xmm0, %xmm0; \
+  pshufd $0, %xmm0, %xmm0
 
 # define WMEMSET_SET_VEC0_AND_SET_RETURN(d, r) \
   movd d, %xmm0; \


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-05 16:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 16:41 [glibc/release/2.34/master] x86: Remove SSSE3 instruction for broadcast in memset.S (SSE2 Only) Sunil Pandey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).