public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/release/2.34/master] string.h: fix __fortified_attr_access macro call [BZ #29162]
@ 2022-05-23  8:41 Siddhesh Poyarekar
  0 siblings, 0 replies; only message in thread
From: Siddhesh Poyarekar @ 2022-05-23  8:41 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=14770f3e0462721b317f138197e1fbf4db542c94

commit 14770f3e0462721b317f138197e1fbf4db542c94
Author: Sergei Trofimovich <slyich@gmail.com>
Date:   Mon May 23 13:56:43 2022 +0530

    string.h: fix __fortified_attr_access macro call [BZ #29162]
    
    commit e938c0274 "Don't add access size hints to fortifiable functions"
    converted a few '__attr_access ((...))' into '__fortified_attr_access (...)'
    calls.
    
    But one of conversions had double parentheses of '__fortified_attr_access (...)'.
    
    Noticed as a gnat6 build failure:
    
        /<<NIX>>-glibc-2.34-210-dev/include/bits/string_fortified.h:110:50: error: macro "__fortified_attr_access" requires 3 arguments, but only 1 given
    
    The change fixes parentheses.
    
    This is seen when using compilers that do not support
    __builtin___stpncpy_chk, e.g. gcc older than 4.7, clang older than 2.6
    or some compiler not derived from gcc or clang.
    
    Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
    Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
    (cherry picked from commit 5a5f94af0542f9a35aaa7992c18eb4e2403a29b9)

Diff:
---
 string/bits/string_fortified.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/string/bits/string_fortified.h b/string/bits/string_fortified.h
index 218006c9ba..4e66e0bd1e 100644
--- a/string/bits/string_fortified.h
+++ b/string/bits/string_fortified.h
@@ -107,7 +107,7 @@ __NTH (stpncpy (char *__dest, const char *__src, size_t __n))
 # else
 extern char *__stpncpy_chk (char *__dest, const char *__src, size_t __n,
 			    size_t __destlen) __THROW
-  __fortified_attr_access ((__write_only__, 1, 3))
+  __fortified_attr_access (__write_only__, 1, 3)
   __attr_access ((__read_only__, 2));
 extern char *__REDIRECT_NTH (__stpncpy_alias, (char *__dest, const char *__src,
 					       size_t __n), stpncpy);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-23  8:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23  8:41 [glibc/release/2.34/master] string.h: fix __fortified_attr_access macro call [BZ #29162] Siddhesh Poyarekar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).