public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] i686: Remove _dl_skip_args usage
@ 2022-05-30 20:49 Adhemerval Zanella
0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2022-05-30 20:49 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1b7f05d11e75594c06f0a8d193c80c7f74857d5f
commit 1b7f05d11e75594c06f0a8d193c80c7f74857d5f
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Thu May 26 13:07:00 2022 -0300
i686: Remove _dl_skip_args usage
Since ad43cac44a the generic code already shuffles the argv/envp/auxv
on the stack to remove the ld.so own arguments and thus _dl_skip_args
is always 0. So there is no need to adjust the argc or argv.
Checked on i686-linux-gnu.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Diff:
---
sysdeps/i386/dl-machine.h | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/sysdeps/i386/dl-machine.h b/sysdeps/i386/dl-machine.h
index 1f8d734215..8779983c8c 100644
--- a/sysdeps/i386/dl-machine.h
+++ b/sysdeps/i386/dl-machine.h
@@ -143,17 +143,8 @@ _dl_start_user:\n\
# Point %ebx at the GOT.\n\
call 0b\n\
addl $_GLOBAL_OFFSET_TABLE_, %ebx\n\
- # See if we were run as a command with the executable file\n\
- # name as an extra leading argument.\n\
- movl _dl_skip_args@GOTOFF(%ebx), %eax\n\
- # Pop the original argument count.\n\
- popl %edx\n\
- # Adjust the stack pointer to skip _dl_skip_args words.\n\
- leal (%esp,%eax,4), %esp\n\
- # Subtract _dl_skip_args from argc.\n\
- subl %eax, %edx\n\
- # Push argc back on the stack.\n\
- push %edx\n\
+ # Read the original argument count.\n\
+ movl (%esp), %edx\n\
# The special initializer gets called with the stack just\n\
# as the application's entry point will see it; it can\n\
# switch stacks if it moves these contents over.\n\
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-30 20:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-30 20:49 [glibc] i686: Remove _dl_skip_args usage Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).