public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] nss: add assert to DB_LOOKUP_FCT (BZ #28752)
@ 2022-06-09 1:30 DJ Delorie
0 siblings, 0 replies; only message in thread
From: DJ Delorie @ 2022-06-09 1:30 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3fdf0a205b622e40fa7e3c4ed1e4ed4d5c6c5380
commit 3fdf0a205b622e40fa7e3c4ed1e4ed4d5c6c5380
Author: Sam James <sam@gentoo.org>
Date: Sun Jun 5 04:57:09 2022 +0100
nss: add assert to DB_LOOKUP_FCT (BZ #28752)
It's interesting if we have a null action list,
so an assert is worthwhile.
Suggested-by: DJ Delorie <dj@redhat.com>
Signed-off-by: Sam James <sam@gentoo.org>
Reviewed-by: DJ Delorie <dj@redhat.com>
Diff:
---
nss/XXX-lookup.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/nss/XXX-lookup.c b/nss/XXX-lookup.c
index db95937674..bfc57b8e64 100644
--- a/nss/XXX-lookup.c
+++ b/nss/XXX-lookup.c
@@ -15,6 +15,7 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
+#include <assert.h>
#include "nsswitch.h"
/*******************************************************************\
@@ -54,6 +55,10 @@ DB_LOOKUP_FCT (nss_action_list *ni, const char *fct_name, const char *fct2_name,
*ni = DATABASE_NAME_SYMBOL;
+ /* We want to know about it if we've somehow got a NULL action list;
+ in the past, we had bad state if seccomp interfered with setup. */
+ assert(*ni != NULL);
+
return __nss_lookup (ni, fct_name, fct2_name, fctp);
}
libc_hidden_def (DB_LOOKUP_FCT)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-09 1:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 1:30 [glibc] nss: add assert to DB_LOOKUP_FCT (BZ #28752) DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).