public inbox for
help / color / mirror / Atom feed
* [glibc] stdlib: Fixup mbstowcs NULL __dst handling. [BZ #29279]
@ 2022-06-23 15:26 Noah Goldstein
  0 siblings, 0 replies; only message in thread
From: Noah Goldstein @ 2022-06-23 15:26 UTC (permalink / raw)
  To: glibc-cvs;h=220b83d83d32aa9e6f5659e2fa2a63a0024c3e4a

commit 220b83d83d32aa9e6f5659e2fa2a63a0024c3e4a
Author: Noah Goldstein <>
Date:   Wed Jun 22 16:34:42 2022 -0700

    stdlib: Fixup mbstowcs NULL __dst handling. [BZ #29279]
    commit 464d189b9622932a75302290625de84931656ec0 (origin/master, origin/HEAD)
    Author: Noah Goldstein <>
    Date:   Wed Jun 22 08:24:21 2022 -0700
        stdlib: Remove attr_write from mbstows if dst is NULL [BZ: 29265]
    Incorrectly called `__mbstowcs_chk` in the NULL __dst case which is
    incorrect as in the NULL __dst case we are explicitly skipping
    the objsize checks.
    As well, remove the `__always_inline` attribute which exists in
    Reviewed-by: Siddhesh Poyarekar <>

 stdlib/bits/stdlib.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/stdlib/bits/stdlib.h b/stdlib/bits/stdlib.h
index d9c2d822a5..de1c3b20f0 100644
--- a/stdlib/bits/stdlib.h
+++ b/stdlib/bits/stdlib.h
@@ -96,10 +96,10 @@ extern size_t __mbstowcs_chk (wchar_t *__restrict __dst,
 			      const char *__restrict __src,
 			      size_t __len, size_t __dstlen) __THROW
     __attr_access ((__write_only__, 1, 3)) __attr_access ((__read_only__, 2));
-extern size_t __REDIRECT_NTH (__mbstowcs_chk_nulldst,
+extern size_t __REDIRECT_NTH (__mbstowcs_nulldst,
 			      (wchar_t *__restrict __dst,
 			       const char *__restrict __src,
-			       size_t __len), mbstowcs_chk)
+			       size_t __len), mbstowcs)
     __attr_access ((__read_only__, 2));
 extern size_t __REDIRECT_NTH (__mbstowcs_alias,
 			      (wchar_t *__restrict __dst,
@@ -113,12 +113,12 @@ extern size_t __REDIRECT_NTH (__mbstowcs_chk_warn,
      __warnattr ("mbstowcs called with dst buffer smaller than len "
 		 "* sizeof (wchar_t)");
-__always_inline __fortify_function size_t
+__fortify_function size_t
 __NTH (mbstowcs (wchar_t *__restrict __dst, const char *__restrict __src,
 		 size_t __len))
   if (__builtin_constant_p (__dst == NULL) && __dst == NULL)
-    return __mbstowcs_chk_nulldst (__dst, __src, __len);
+    return __mbstowcs_nulldst (__dst, __src, __len);
     return __glibc_fortify_n (mbstowcs, __len, sizeof (wchar_t),
 			      __glibc_objsize (__dst), __dst, __src, __len);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-23 15:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-23 15:26 [glibc] stdlib: Fixup mbstowcs NULL __dst handling. [BZ #29279] Noah Goldstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).