public inbox for
help / color / mirror / Atom feed
From: Noah Goldstein <>
Subject: [glibc] x86: Remove faulty sanity tests for RTLD build with no multiarch
Date: Thu, 23 Jun 2022 18:14:25 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=bd42891bb38d43878d0a9e204a183dbae4a2c6d0

commit bd42891bb38d43878d0a9e204a183dbae4a2c6d0
Author: Noah Goldstein <>
Date:   Thu Jun 23 10:49:19 2022 -0700

    x86: Remove faulty sanity tests for RTLD build with no multiarch
    The sanity tests where meant to ensure that the default implementation
    was only being built without multiarch with the exception of the
    multiarch/rtld-*.S files.
    The code used IS_IN (rtld) to check if the build for was for an
    multiarch/rtld-*.S file which is incorrect as IS_IN (rtld) is set for
    the non-multiarch build as well.

 sysdeps/x86_64/isa-default-impl.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/sysdeps/x86_64/isa-default-impl.h b/sysdeps/x86_64/isa-default-impl.h
index 7d7832b1f5..34634668e5 100644
--- a/sysdeps/x86_64/isa-default-impl.h
+++ b/sysdeps/x86_64/isa-default-impl.h
@@ -46,14 +46,4 @@
 # error "Unsupported ISA Level!"
-#if IS_IN(rtld)
-# if !defined USE_MULTIARCH
-#  error "RTLD version should only exist in multiarch build"
-# endif
-# if defined USE_MULTIARCH
-#  error "Multiarch build should not use ISA_DEFAULT_IMPL without RTLD"
-# endif

                 reply	other threads:[~2022-06-23 18:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).