public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] x86: Remove faulty sanity tests for RTLD build with no multiarch
@ 2022-06-23 18:14 Noah Goldstein
0 siblings, 0 replies; only message in thread
From: Noah Goldstein @ 2022-06-23 18:14 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bd42891bb38d43878d0a9e204a183dbae4a2c6d0
commit bd42891bb38d43878d0a9e204a183dbae4a2c6d0
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date: Thu Jun 23 10:49:19 2022 -0700
x86: Remove faulty sanity tests for RTLD build with no multiarch
The sanity tests where meant to ensure that the default implementation
was only being built without multiarch with the exception of the
multiarch/rtld-*.S files.
The code used IS_IN (rtld) to check if the build for was for an
multiarch/rtld-*.S file which is incorrect as IS_IN (rtld) is set for
the non-multiarch build as well.
Diff:
---
sysdeps/x86_64/isa-default-impl.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/sysdeps/x86_64/isa-default-impl.h b/sysdeps/x86_64/isa-default-impl.h
index 7d7832b1f5..34634668e5 100644
--- a/sysdeps/x86_64/isa-default-impl.h
+++ b/sysdeps/x86_64/isa-default-impl.h
@@ -46,14 +46,4 @@
# error "Unsupported ISA Level!"
#endif
-#if IS_IN(rtld)
-# if !defined USE_MULTIARCH
-# error "RTLD version should only exist in multiarch build"
-# endif
-#else
-# if defined USE_MULTIARCH
-# error "Multiarch build should not use ISA_DEFAULT_IMPL without RTLD"
-# endif
-#endif
-
#include ISA_DEFAULT_IMPL
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-23 18:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-23 18:14 [glibc] x86: Remove faulty sanity tests for RTLD build with no multiarch Noah Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).