public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] elf: Fix direction of NODELETE log messages during symbol lookup Date: Tue, 5 Jul 2022 12:40:46 +0000 (GMT) [thread overview] Message-ID: <20220705124046.9C9FE3858292@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a9f9ee2381944cee8b4b50c5c8321e3529c77e49 commit a9f9ee2381944cee8b4b50c5c8321e3529c77e49 Author: Florian Weimer <fweimer@redhat.com> Date: Tue Jul 5 14:40:38 2022 +0200 elf: Fix direction of NODELETE log messages during symbol lookup NODELETE status is propagated from the referencing object to the referenced object, not the other way round. The code is correct, only the log message has the wrong direction. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Diff: --- elf/dl-lookup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c index 8cb32321da..4c86dc694e 100644 --- a/elf/dl-lookup.c +++ b/elf/dl-lookup.c @@ -646,11 +646,11 @@ add_dependency (struct link_map *undef_map, struct link_map *map, int flags) { if (undef_map->l_name[0] == '\0') _dl_debug_printf ("\ -marking %s [%lu] as NODELETE due to reference to main program\n", +marking %s [%lu] as NODELETE due to reference from main program\n", map->l_name, map->l_ns); else _dl_debug_printf ("\ -marking %s [%lu] as NODELETE due to reference to %s [%lu]\n", +marking %s [%lu] as NODELETE due to reference from %s [%lu]\n", map->l_name, map->l_ns, undef_map->l_name, undef_map->l_ns); }
reply other threads:[~2022-07-05 12:40 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220705124046.9C9FE3858292@sourceware.org \ --to=fw@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).