public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] elf: Fix direction of NODELETE log messages during symbol lookup
@ 2022-07-05 12:40 Florian Weimer
  0 siblings, 0 replies; only message in thread
From: Florian Weimer @ 2022-07-05 12:40 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a9f9ee2381944cee8b4b50c5c8321e3529c77e49

commit a9f9ee2381944cee8b4b50c5c8321e3529c77e49
Author: Florian Weimer <fweimer@redhat.com>
Date:   Tue Jul 5 14:40:38 2022 +0200

    elf: Fix direction of NODELETE log messages during symbol lookup
    
    NODELETE status is propagated from the referencing object to the
    referenced object, not the other way round.  The code is correct, only
    the log message has the wrong direction.
    
    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Diff:
---
 elf/dl-lookup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c
index 8cb32321da..4c86dc694e 100644
--- a/elf/dl-lookup.c
+++ b/elf/dl-lookup.c
@@ -646,11 +646,11 @@ add_dependency (struct link_map *undef_map, struct link_map *map, int flags)
 	    {
 	      if (undef_map->l_name[0] == '\0')
 		_dl_debug_printf ("\
-marking %s [%lu] as NODELETE due to reference to main program\n",
+marking %s [%lu] as NODELETE due to reference from main program\n",
 				  map->l_name, map->l_ns);
 	      else
 		_dl_debug_printf ("\
-marking %s [%lu] as NODELETE due to reference to %s [%lu]\n",
+marking %s [%lu] as NODELETE due to reference from %s [%lu]\n",
 				  map->l_name, map->l_ns,
 				  undef_map->l_name, undef_map->l_ns);
 	    }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-05 12:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 12:40 [glibc] elf: Fix direction of NODELETE log messages during symbol lookup Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).