public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Sunil Pandey <skpgkp2@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/release/2.35/master] x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S
Date: Mon, 18 Jul 2022 20:59:13 +0000 (GMT)	[thread overview]
Message-ID: <20220718205913.883513852779@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c4050b25527c80a989b5f3349b7ea2bf5acf3fd2

commit c4050b25527c80a989b5f3349b7ea2bf5acf3fd2
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Wed Jun 29 18:56:18 2022 -0700

    x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S
    
    Was missing to for the multiarch build rtld-strncmp-sse4_2.os was
    being built and exporting symbols:
    
    build/glibc/string/rtld-strncmp-sse4_2.os:
    0000000000000000 T __strncmp_sse42
    
    Introduced in:
    
    commit 11ffcacb64a939c10cfc713746b8ec88837f5c4a
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Wed Jun 21 12:10:50 2017 -0700
    
        x86-64: Implement strcmp family IFUNC selectors in C
    
    (cherry picked from commit 96ac447d915ea5ecef3f9168cc13f4e731349a3b)

Diff:
---
 sysdeps/x86_64/multiarch/strncmp-sse4_2.S | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
index 9773e5fc09..310a6dbe77 100644
--- a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
+++ b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
@@ -16,6 +16,8 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#define STRCMP_SSE42 __strncmp_sse42
-#define USE_AS_STRNCMP
-#include "strcmp-sse42.S"
+#if IS_IN (libc)
+# define STRCMP_SSE42 __strncmp_sse42
+# define USE_AS_STRNCMP
+# include "strcmp-sse42.S"
+#endif


                 reply	other threads:[~2022-07-18 20:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718205913.883513852779@sourceware.org \
    --to=skpgkp2@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).