public inbox for
help / color / mirror / Atom feed
* [glibc] i386: Avoid rely on linker optimization to avoid relocation
@ 2022-11-21 14:36 Adhemerval Zanella
  0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2022-11-21 14:36 UTC (permalink / raw)
  To: glibc-cvs;h=59aa41585f668b70b86a8e2617057da08f3291cc

commit 59aa41585f668b70b86a8e2617057da08f3291cc
Author: Adhemerval Zanella Netto <>
Date:   Thu Nov 17 15:13:08 2022 -0300

    i386: Avoid rely on linker optimization to avoid relocation
    lld does not implement all the linker optimization to avoid the GOT
    relocation as done by binutils (bfd/elf32-i386.c:elf_i386_convert_load_reloc).
    The current 'movl main@GOT(%ebx), %eax' will then create a GOT
    relocation when building with lld, which make static-pie status to
    not being able to start the provided main function.
    The change uses a __wrap_main local symbol, which in turn calls main
    (similar as used by aarch64 and s390x).
    Checked on i686-linux-gnu with binutils and lld.
    Reviewed-by: Fangrui Song <>

 sysdeps/i386/start.S | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/sysdeps/i386/start.S b/sysdeps/i386/start.S
index 4ec04bdfd7..23e4f2b012 100644
--- a/sysdeps/i386/start.S
+++ b/sysdeps/i386/start.S
@@ -98,11 +98,10 @@ ENTRY (_start)
 	pushl main@GOT(%ebx)
 # else
 	/* Avoid relocation in static PIE since _start is called before
-	   it is relocated.  Don't use "leal main@GOTOFF(%ebx), %eax"
-	   since main may be in a shared object.  Linker will convert
-	   "movl main@GOT(%ebx), %eax" to "leal main@GOTOFF(%ebx), %eax"
+	   it is relocated.  This also avoid rely on linker optimization to
+	   transform 'movl main@GOT(%ebx), %eax' to 'leal main@GOTOFF(%ebx)'
 	   if main is defined locally.  */
-	movl main@GOT(%ebx), %eax
+	leal __wrap_main@GOTOFF(%ebx), %eax
 	pushl %eax
 # endif
@@ -130,6 +129,12 @@ ENTRY (_start)
 1:	movl	(%esp), %ebx
+#if defined PIC && !defined SHARED
+	jmp	main@PLT
 END (_start)
 /* To fulfill the System V/i386 ABI we need this symbol.  Yuck, it's so

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-21 14:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 14:36 [glibc] i386: Avoid rely on linker optimization to avoid relocation Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).