public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/arm/morello/main] Fix elf/tst-dlmopen-twice to support enough link namespaces
@ 2022-11-23 14:40 Szabolcs Nagy
  0 siblings, 0 replies; 3+ messages in thread
From: Szabolcs Nagy @ 2022-11-23 14:40 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d4a845daaf05e22207243b69624def1ee59607ac

commit d4a845daaf05e22207243b69624def1ee59607ac
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Tue Oct 18 16:33:52 2022 +0100

    Fix elf/tst-dlmopen-twice to support enough link namespaces
    
    The test dlmopens 10 namespaces recursively, which requires a glibc
    tunable setting, otherwise it may run out of static TLS.

Diff:
---
 elf/Makefile            | 1 +
 elf/tst-dlmopen-twice.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/elf/Makefile b/elf/Makefile
index 72178d33ff..399b709a7d 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -2979,6 +2979,7 @@ tst-audit-tlsdesc-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
 $(objpfx)tst-audit-tlsdesc-dlopen.out: $(objpfx)tst-auditmod-tlsdesc.so
 tst-audit-tlsdesc-dlopen-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
 
+tst-dlmopen-twice-ENV = GLIBC_TUNABLES=glibc.rtld.nns=10
 $(objpfx)tst-dlmopen-twice.out: \
   $(objpfx)tst-dlmopen-twice-mod1.so \
   $(objpfx)tst-dlmopen-twice-mod2.so
diff --git a/elf/tst-dlmopen-twice.c b/elf/tst-dlmopen-twice.c
index 70c71fe19c..dfa58b1505 100644
--- a/elf/tst-dlmopen-twice.c
+++ b/elf/tst-dlmopen-twice.c
@@ -46,7 +46,7 @@ do_test (void)
   recurse (1);
 
   /* Then with nesting.  The constant needs to be less than the
-     internal DL_NNS namespace constant.  */
+     glibc.rtld.nns tunable (which is between 1 and DL_NNS).  */
   recurse (10);
   return 0;
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [glibc/arm/morello/main] Fix elf/tst-dlmopen-twice to support enough link namespaces
@ 2022-10-27 13:50 Szabolcs Nagy
  0 siblings, 0 replies; 3+ messages in thread
From: Szabolcs Nagy @ 2022-10-27 13:50 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ae60f3996dc52bad4fd8ecb83315fa974549c0e6

commit ae60f3996dc52bad4fd8ecb83315fa974549c0e6
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Tue Oct 18 16:33:52 2022 +0100

    Fix elf/tst-dlmopen-twice to support enough link namespaces
    
    The test dlmopens 10 namespaces recursively, which requires a glibc
    tunable setting, otherwise it may run out of static TLS.

Diff:
---
 elf/Makefile            | 1 +
 elf/tst-dlmopen-twice.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/elf/Makefile b/elf/Makefile
index 72178d33ff..399b709a7d 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -2979,6 +2979,7 @@ tst-audit-tlsdesc-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
 $(objpfx)tst-audit-tlsdesc-dlopen.out: $(objpfx)tst-auditmod-tlsdesc.so
 tst-audit-tlsdesc-dlopen-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
 
+tst-dlmopen-twice-ENV = GLIBC_TUNABLES=glibc.rtld.nns=10
 $(objpfx)tst-dlmopen-twice.out: \
   $(objpfx)tst-dlmopen-twice-mod1.so \
   $(objpfx)tst-dlmopen-twice-mod2.so
diff --git a/elf/tst-dlmopen-twice.c b/elf/tst-dlmopen-twice.c
index 70c71fe19c..dfa58b1505 100644
--- a/elf/tst-dlmopen-twice.c
+++ b/elf/tst-dlmopen-twice.c
@@ -46,7 +46,7 @@ do_test (void)
   recurse (1);
 
   /* Then with nesting.  The constant needs to be less than the
-     internal DL_NNS namespace constant.  */
+     glibc.rtld.nns tunable (which is between 1 and DL_NNS).  */
   recurse (10);
   return 0;
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [glibc/arm/morello/main] Fix elf/tst-dlmopen-twice to support enough link namespaces
@ 2022-10-26 15:10 Szabolcs Nagy
  0 siblings, 0 replies; 3+ messages in thread
From: Szabolcs Nagy @ 2022-10-26 15:10 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a574b49a21e36cdcefec629c2353a830dee0a05f

commit a574b49a21e36cdcefec629c2353a830dee0a05f
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Tue Oct 18 16:33:52 2022 +0100

    Fix elf/tst-dlmopen-twice to support enough link namespaces
    
    The test dlmopens 10 namespaces recursively, which requires a glibc
    tunable setting, otherwise it may run out of static TLS.

Diff:
---
 elf/Makefile            | 1 +
 elf/tst-dlmopen-twice.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/elf/Makefile b/elf/Makefile
index 72178d33ff..399b709a7d 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -2979,6 +2979,7 @@ tst-audit-tlsdesc-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
 $(objpfx)tst-audit-tlsdesc-dlopen.out: $(objpfx)tst-auditmod-tlsdesc.so
 tst-audit-tlsdesc-dlopen-ENV = LD_AUDIT=$(objpfx)tst-auditmod-tlsdesc.so
 
+tst-dlmopen-twice-ENV = GLIBC_TUNABLES=glibc.rtld.nns=10
 $(objpfx)tst-dlmopen-twice.out: \
   $(objpfx)tst-dlmopen-twice-mod1.so \
   $(objpfx)tst-dlmopen-twice-mod2.so
diff --git a/elf/tst-dlmopen-twice.c b/elf/tst-dlmopen-twice.c
index 70c71fe19c..dfa58b1505 100644
--- a/elf/tst-dlmopen-twice.c
+++ b/elf/tst-dlmopen-twice.c
@@ -46,7 +46,7 @@ do_test (void)
   recurse (1);
 
   /* Then with nesting.  The constant needs to be less than the
-     internal DL_NNS namespace constant.  */
+     glibc.rtld.nns tunable (which is between 1 and DL_NNS).  */
   recurse (10);
   return 0;
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-23 14:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-23 14:40 [glibc/arm/morello/main] Fix elf/tst-dlmopen-twice to support enough link namespaces Szabolcs Nagy
  -- strict thread matches above, loose matches on Subject: below --
2022-10-27 13:50 Szabolcs Nagy
2022-10-26 15:10 Szabolcs Nagy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).