public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] elf: Fix tst-relro-symbols.py argument passing Date: Thu, 15 Dec 2022 19:59:24 +0000 (GMT) [thread overview] Message-ID: <20221215195924.4739B38983A3@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=71e408e45dcacf429a94b2807f75aaadd8d37cb9 commit 71e408e45dcacf429a94b2807f75aaadd8d37cb9 Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Wed Dec 14 18:18:34 2022 -0300 elf: Fix tst-relro-symbols.py argument passing Current scheme only consideres the first argument for both --required and --optional, where the idea is to append a new item. Checked on x86_64-linux-gnu. Reviewed-by: Florian Weimer <fweimer@redhat.com> Diff: --- elf/tst-relro-symbols.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/elf/tst-relro-symbols.py b/elf/tst-relro-symbols.py index 368ea3349f..ea61024b5e 100644 --- a/elf/tst-relro-symbols.py +++ b/elf/tst-relro-symbols.py @@ -56,10 +56,10 @@ def get_parser(): """Return an argument parser for this script.""" parser = argparse.ArgumentParser(description=__doc__) parser.add_argument('object', help='path to object file to check') - parser.add_argument('--required', metavar='NAME', default=(), - help='required symbol names', nargs='*') - parser.add_argument('--optional', metavar='NAME', default=(), - help='required symbol names', nargs='*') + parser.add_argument('--required', metavar='NAME', action='append', + default=[], help='required symbol names') + parser.add_argument('--optional', metavar='NAME', action='append', + default=[], help='required symbol names') return parser def main(argv):
reply other threads:[~2022-12-15 19:59 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221215195924.4739B38983A3@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).