public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] hurd _S_msg_add_auth: Initialize new arrays to 0
@ 2023-01-02 10:36 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2023-01-02 10:36 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6514b2d59545300b27785abaaacd0115ff61a18d
commit 6514b2d59545300b27785abaaacd0115ff61a18d
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Mon Jan 2 01:08:38 2023 +0100
hurd _S_msg_add_auth: Initialize new arrays to 0
If make_list fails, they would be undefined, and freeup with free
uninitialized pointers.
Diff:
---
hurd/hurdauth.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/hurd/hurdauth.c b/hurd/hurdauth.c
index 9086e9484c..25cc8ee88d 100644
--- a/hurd/hurdauth.c
+++ b/hurd/hurdauth.c
@@ -101,21 +101,24 @@ _S_msg_add_auth (mach_port_t me,
__mutex_lock (&_hurd_id.lock);
_hurd_check_ids ();
-#define MAKE(genaux,uidgid) \
- make_list (&new ## genaux ## uidgid ## s, \
+#define MAKE(genaux,uidgid) ({ \
+ new ## genaux ## uidgid ## s = 0; \
+ nnew ## genaux ## uidgid ## s = 0; \
+ make_list (&new ## genaux ## uidgid ## s, \
&nnew ## genaux ## uidgid ## s, \
_hurd_id.genaux.uidgid ## s, \
_hurd_id.genaux.n ## uidgid ## s, \
genaux ## uidgid ## s, \
- n ## genaux ## uidgid ## s)
+ n ## genaux ## uidgid ## s); \
+})
err = MAKE (gen, uid);
if (!err)
- MAKE (aux, uid);
+ err = MAKE (aux, uid);
if (!err)
- MAKE (gen, gid);
+ err = MAKE (gen, gid);
if (!err)
- MAKE (aux, gid);
+ err = MAKE (aux, gid);
#undef MAKE
__mutex_unlock (&_hurd_id.lock);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-02 10:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-02 10:36 [glibc] hurd _S_msg_add_auth: Initialize new arrays to 0 Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).