public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] ARC:fpu: add extra capability check before use of sqrt and fma builtins
@ 2023-02-17 19:39 Adhemerval Zanella
  0 siblings, 0 replies; only message in thread
From: Adhemerval Zanella @ 2023-02-17 19:39 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=dab63442791e334d592ce91827ffa9d14ca92ea9

commit dab63442791e334d592ce91827ffa9d14ca92ea9
Author: Pavel Kozlov <pavel.kozlov@synopsys.com>
Date:   Tue Jan 17 16:12:23 2023 +0400

    ARC:fpu: add extra capability check before use of sqrt and fma builtins
    
    Add extra check for compiler definitions to ensure that compiler provides
    sqrt and fma hw fpu instructions else use software implementation.
    
    As divide/sqrt and FMA hw support from CPU side is optional,
    the compiler can be configured by options to generate hw FPU instructions,
    but without use of FDDIV, FDSQRT, FSDIV, FSSQRT, FDMADD and FSMADD
    instructions. In this case __builtin_sqrt and __builtin_sqrtf provided by
    compiler can't be used inside the glibc code, as these builtins are used
    in implementations of sqrt() and sqrtf() functions but at the same time
    these builtins unfold to sqrt() and sqrtf(). So it is possible to receive
    code like that:
    
    0001c4b4 <__ieee754_sqrtf>:
       1c4b4:    0001 0000      b     0         ;1c4b4 <__ieee754_sqrtf>
    
    The same is also true for __builtin_fma and __builtin_fmaf.
    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Diff:
---
 sysdeps/arc/fpu/math-use-builtins-fma.h  | 14 ++++++++++++--
 sysdeps/arc/fpu/math-use-builtins-sqrt.h | 14 ++++++++++++--
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/sysdeps/arc/fpu/math-use-builtins-fma.h b/sysdeps/arc/fpu/math-use-builtins-fma.h
index eede75aa41..2acd8113ce 100644
--- a/sysdeps/arc/fpu/math-use-builtins-fma.h
+++ b/sysdeps/arc/fpu/math-use-builtins-fma.h
@@ -1,4 +1,14 @@
-#define USE_FMA_BUILTIN 1
-#define USE_FMAF_BUILTIN 1
+#if defined __ARC_FPU_DP_FMA__
+# define USE_FMA_BUILTIN 1
+#else
+# define USE_FMA_BUILTIN 0
+#endif
+
+#if defined __ARC_FPU_SP_FMA__
+# define USE_FMAF_BUILTIN 1
+#else
+# define USE_FMAF_BUILTIN 0
+#endif
+
 #define USE_FMAL_BUILTIN 0
 #define USE_FMAF128_BUILTIN 0
diff --git a/sysdeps/arc/fpu/math-use-builtins-sqrt.h b/sysdeps/arc/fpu/math-use-builtins-sqrt.h
index e94c915ba6..a449bc6092 100644
--- a/sysdeps/arc/fpu/math-use-builtins-sqrt.h
+++ b/sysdeps/arc/fpu/math-use-builtins-sqrt.h
@@ -1,4 +1,14 @@
-#define USE_SQRT_BUILTIN 1
-#define USE_SQRTF_BUILTIN 1
+#if defined __ARC_FPU_DP_DIV__
+# define USE_SQRT_BUILTIN 1
+#else
+# define USE_SQRT_BUILTIN 0
+#endif
+
+#if defined __ARC_FPU_SP_DIV__
+# define USE_SQRTF_BUILTIN 1
+#else
+# define USE_SQRTF_BUILTIN 0
+#endif
+
 #define USE_SQRTL_BUILTIN 0
 #define USE_SQRTF128_BUILTIN 0

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-17 19:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 19:39 [glibc] ARC:fpu: add extra capability check before use of sqrt and fma builtins Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).