public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] LoongArch: ldconfig: Ignore EF_LARCH_OBJABI_V1 in shared objects
@ 2023-03-27  8:58 Yinyu Cai
  0 siblings, 0 replies; only message in thread
From: Yinyu Cai @ 2023-03-27  8:58 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=952b7630c72ae245f370f1a2bcaade82bb1f7361

commit 952b7630c72ae245f370f1a2bcaade82bb1f7361
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Sun Mar 26 19:13:34 2023 +0800

    LoongArch: ldconfig: Ignore EF_LARCH_OBJABI_V1 in shared objects
    
    Binutils 2.40 sets EF_LARCH_OBJABI_V1 for shared objects:
    
        $ ld --version | head -n1
        GNU ld (GNU Binutils) 2.40
        $ echo 'int dummy;' > dummy.c
        $ cc dummy.c -shared
        $ readelf -h a.out | grep Flags
        Flags:                             0x43, DOUBLE-FLOAT, OBJ-v1
    
    We need to ignore it in ldconfig or ldconfig will consider all shared
    objects linked by Binutils 2.40 "unsupported".  Maybe we should stop
    setting EF_LARCH_OBJABI_V1 for shared objects, but Binutils 2.40 is
    already released and we cannot change it.

Diff:
---
 sysdeps/unix/sysv/linux/loongarch/readelflib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/unix/sysv/linux/loongarch/readelflib.c b/sysdeps/unix/sysv/linux/loongarch/readelflib.c
index bcaff86b36..ceba355959 100644
--- a/sysdeps/unix/sysv/linux/loongarch/readelflib.c
+++ b/sysdeps/unix/sysv/linux/loongarch/readelflib.c
@@ -40,7 +40,7 @@ process_elf_file (const char *file_name, const char *lib, int *flag,
 
   ret = process_elf64_file (file_name, lib, flag, isa_level, soname,
 				file_contents, file_length);
-  flags = elf64_header->e_flags;
+  flags = elf64_header->e_flags & ~EF_LARCH_OBJABI_V1;
 
   /* LoongArch linkers encode the floating point ABI as part of the ELF headers.  */
   switch (flags & SUPPORTED_ELF_FLAGS)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-27  8:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-27  8:58 [glibc] LoongArch: ldconfig: Ignore EF_LARCH_OBJABI_V1 in shared objects Yinyu Cai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).