public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] hurd: Do not declare local variables volatile
@ 2023-04-10 18:42 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2023-04-10 18:42 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=645da826bba8c37d834403a56dc94203052c2cee
commit 645da826bba8c37d834403a56dc94203052c2cee
Author: Sergey Bugaev <bugaevc@gmail.com>
Date: Mon Apr 3 14:56:20 2023 +0300
hurd: Do not declare local variables volatile
These are just regular local variables that are not accessed in any
funny ways, not even though a pointer. There's absolutely no reason to
declare them volatile. It only ends up hurting the quality of the
generated machine code.
If anything, it would make sense to decalre sigsp as *pointing* to
volatile memory (volatile void *sigsp), but evidently that's not needed
either.
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230403115621.258636-2-bugaevc@gmail.com>
Diff:
---
hurd/trampoline.c | 2 +-
sysdeps/mach/hurd/i386/trampoline.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hurd/trampoline.c b/hurd/trampoline.c
index 5bd8dec919..1447b13fe6 100644
--- a/hurd/trampoline.c
+++ b/hurd/trampoline.c
@@ -29,7 +29,7 @@ struct sigcontext *
_hurd_setup_sighandler (struct hurd_sigstate *ss, const struct sigaction *action,
__sighandler_t handler,
int signo, struct hurd_signal_detail *detail,
- volatile int rpc_wait,
+ int rpc_wait,
struct machine_thread_all_state *state)
{
#error "Need to write sysdeps/mach/hurd/MACHINE/trampoline.c"
diff --git a/sysdeps/mach/hurd/i386/trampoline.c b/sysdeps/mach/hurd/i386/trampoline.c
index ab67fb9cd2..9cd60b9c8f 100644
--- a/sysdeps/mach/hurd/i386/trampoline.c
+++ b/sysdeps/mach/hurd/i386/trampoline.c
@@ -83,13 +83,13 @@ struct sigcontext *
_hurd_setup_sighandler (struct hurd_sigstate *ss, const struct sigaction *action,
__sighandler_t handler,
int signo, struct hurd_signal_detail *detail,
- volatile int rpc_wait,
+ int rpc_wait,
struct machine_thread_all_state *state)
{
void trampoline (void);
void rpc_wait_trampoline (void);
void firewall (void);
- void *volatile sigsp;
+ void *sigsp;
struct sigcontext *scp;
struct
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-10 18:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-10 18:42 [glibc] hurd: Do not declare local variables volatile Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).