public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] hurd: Simplify _hurd_critical_section_lock a bit
@ 2023-04-29 14:50 Samuel Thibault
0 siblings, 0 replies; only message in thread
From: Samuel Thibault @ 2023-04-29 14:50 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c287ecd99133cd82413ad99f2f167628b2df670c
commit c287ecd99133cd82413ad99f2f167628b2df670c
Author: Sergey Bugaev <bugaevc@gmail.com>
Date: Sat Apr 29 16:13:48 2023 +0300
hurd: Simplify _hurd_critical_section_lock a bit
This block of code was doing exactly what _hurd_self_sigstate does; so
just call that and let it do its job.
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230429131354.2507443-1-bugaevc@gmail.com>
Diff:
---
hurd/hurd/signal.h | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/hurd/hurd/signal.h b/hurd/hurd/signal.h
index 662e955e94..b8af6f289a 100644
--- a/hurd/hurd/signal.h
+++ b/hurd/hurd/signal.h
@@ -170,6 +170,11 @@ _hurd_self_sigstate (void)
if (__glibc_unlikely (ss == NULL))
{
thread_t self = __mach_thread_self ();
+
+ /* The thread variable is unset; this must be the first time we've
+ asked for it. In this case, the critical section flag cannot
+ possible already be set. Look up our sigstate structure the slow
+ way. */
ss = _hurd_thread_sigstate (self);
THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, ss);
__mach_port_deallocate (__mach_task_self (), self);
@@ -218,19 +223,7 @@ _hurd_critical_section_lock (void)
return NULL;
#endif
- ss = THREAD_GETMEM (THREAD_SELF, _hurd_sigstate);
- if (ss == NULL)
- {
- thread_t self = __mach_thread_self ();
-
- /* The thread variable is unset; this must be the first time we've
- asked for it. In this case, the critical section flag cannot
- possible already be set. Look up our sigstate structure the slow
- way. */
- ss = _hurd_thread_sigstate (self);
- THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, ss);
- __mach_port_deallocate (__mach_task_self (), self);
- }
+ ss = _hurd_self_sigstate ();
if (! __spin_try_lock (&ss->critical_section_lock))
/* We are already in a critical section, so do nothing. */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-04-29 14:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-29 14:50 [glibc] hurd: Simplify _hurd_critical_section_lock a bit Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).