public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] tests: replace ftruncate by xftruncate
@ 2023-06-01 17:24 Siddhesh Poyarekar
0 siblings, 0 replies; only message in thread
From: Siddhesh Poyarekar @ 2023-06-01 17:24 UTC (permalink / raw)
To: glibc-cvs
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=32043daaafcd59793b9addf7af1bcedb3b666f09
commit 32043daaafcd59793b9addf7af1bcedb3b666f09
Author: Frédéric Bérat <fberat@redhat.com>
Date: Fri Apr 28 14:21:39 2023 +0200
tests: replace ftruncate by xftruncate
With fortification enabled, ftruncate calls return result needs to be
checked, has it gets the __wur macro enabled.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Diff:
---
io/tst-copy_file_range.c | 2 +-
posix/tst-getopt-cancel.c | 3 ++-
stdio-common/tst-perror.c | 3 ++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/io/tst-copy_file_range.c b/io/tst-copy_file_range.c
index d1f3aaa5a9..bd64e9c42b 100644
--- a/io/tst-copy_file_range.c
+++ b/io/tst-copy_file_range.c
@@ -166,7 +166,7 @@ short_copy (void)
inoff = 3;
xlseek (infd, shift, SEEK_SET);
}
- ftruncate (outfd, 0);
+ xftruncate (outfd, 0);
xlseek (outfd, 0, SEEK_SET);
outoff = 0;
diff --git a/posix/tst-getopt-cancel.c b/posix/tst-getopt-cancel.c
index 7167d1a914..6f49391690 100644
--- a/posix/tst-getopt-cancel.c
+++ b/posix/tst-getopt-cancel.c
@@ -33,6 +33,7 @@
#include <support/support.h>
#include <support/temp_file.h>
#include <support/xthread.h>
+#include <support/xunistd.h>
static bool
check_stderr (bool expect_errmsg, FILE *stderr_trapped)
@@ -48,7 +49,7 @@ check_stderr (bool expect_errmsg, FILE *stderr_trapped)
fputs (lineptr, stdout);
}
rewind (stderr_trapped);
- ftruncate (fileno (stderr_trapped), 0);
+ xftruncate (fileno (stderr_trapped), 0);
return got_errmsg == expect_errmsg;
}
diff --git a/stdio-common/tst-perror.c b/stdio-common/tst-perror.c
index 57835e0c59..b4ab583462 100644
--- a/stdio-common/tst-perror.c
+++ b/stdio-common/tst-perror.c
@@ -9,6 +9,7 @@
#include <unistd.h>
#include <wchar.h>
+#include <support/xunistd.h>
#define MB_EXP \
"null mode test 1: Invalid or incomplete multibyte or wide character\n" \
@@ -94,7 +95,7 @@ do_test (void)
puts ("multibyte test succeeded");
lseek (fd, 0, SEEK_SET);
- ftruncate (fd, 0);
+ xftruncate (fd, 0);
if (dup2 (fd, 2) == -1)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-01 17:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 17:24 [glibc] tests: replace ftruncate by xftruncate Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).