public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Arjun Shankar <arjun@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] Remove unused DATEMSK file for tst-getdate Date: Fri, 9 Jun 2023 14:26:20 +0000 (GMT) [thread overview] Message-ID: <20230609142620.BED833858D3C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5e8d1b0328a850c229146f40e18848728b104583 commit 5e8d1b0328a850c229146f40e18848728b104583 Author: Martin Coufal <mcoufal@redhat.com> Date: Fri Jun 9 13:58:04 2023 +0200 Remove unused DATEMSK file for tst-getdate tst-getdate used to rely on an in-tree datemsk file that was subsequently replaced by a file created during test execution. This commit removes the unused file and corresponding env-var and uses a more appropriate name for the temp file. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Diff: --- time/Makefile | 1 - time/datemsk | 2 -- time/tst-getdate.c | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/time/Makefile b/time/Makefile index 92bc3db315..1d2e667cad 100644 --- a/time/Makefile +++ b/time/Makefile @@ -104,7 +104,6 @@ CFLAGS-mktime.c += $(config-cflags-wno-ignored-attributes) # Don't warn about Y2k problem in strftime format string. CFLAGS-test_time.c += -Wno-format -tst-getdate-ENV= DATEMSK=datemsk TZDIR=${common-objpfx}timezone/testdata test_time-ARGS= EST5EDT CST tst-tzname-ENV = TZDIR=${common-objpfx}timezone/testdata diff --git a/time/datemsk b/time/datemsk deleted file mode 100644 index 3dc4d417fe..0000000000 --- a/time/datemsk +++ /dev/null @@ -1,2 +0,0 @@ -%H:%M:%S %F -%d-%m-%Y %T diff --git a/time/tst-getdate.c b/time/tst-getdate.c index cf97e220f7..4c9ed28d58 100644 --- a/time/tst-getdate.c +++ b/time/tst-getdate.c @@ -98,7 +98,7 @@ static const char datemskstr[] = static void do_prepare (int argc, char **argv) { - int fd = create_temp_file ("tst-chk1.", &datemsk); + int fd = create_temp_file ("tst-getdate.", &datemsk); xwrite (fd, datemskstr, sizeof (datemskstr) - 1); setenv ("DATEMSK", datemsk, 1);
reply other threads:[~2023-06-09 14:26 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230609142620.BED833858D3C@sourceware.org \ --to=arjun@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).